-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase certificates PR on Hugo master #9842
Conversation
Co-authored-by: liztio <[email protected]>
n.b. to reviewers and approvers: the content of this PR is already tech reviewed (see related PR). I offered to take over the Hugo rebase from the original author, who is credited as co-author on this PR. Please lgtm and approve, thanks! |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 91a7702 https://deploy-preview-9842--kubernetes-io-master-staging.netlify.com |
|
||
## Where certificates are stored | ||
|
||
Kubernetes stores certificates by default in `/etc/kubernetes/pki`. All paths in this documentation are relative to that directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to clarify that this is the default for kubeadm-installed clusters specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| Default CN | Parent CA | O (in Subject) | kind | hosts (SAN) | | ||
|-------------------------------|---------------------------|----------------|----------------------------------------|---------------------------------------------| | ||
| kube-etcd | etcd-ca | | server, client [<sup>1</sup>][etcdbug] | `localhost`, `127.0.0.1` | | ||
| kube-etcd-peer | etcd-ca | | peer | `<hostname>`, `<Host_IP>`, `localhost`, `127.0.0.1` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be better to standardize both of these to either use server, client
or peer
, rather than using both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
## Configure certificates for user accounts | ||
|
||
You must manually configure thesee administrator account and service accounts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/thesee/these/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
| kind | TLS role | | ||
|--------|---------------------------------------------------------------------------------------------------| | ||
| server | Digital Signature, Key Encipherment, TLS Web Server Authentication | | ||
| peer | Digital Signature, Key Encipherment, TLS Web Server Authentication, TLS Web Client Authentication | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peer here is no longer referenced.
Great job!!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradtopol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: liztio [email protected]
Finally rebasing #8232 on Hugo, with many thanks to @liztio for all her patience.
Added a couple of stray fixes to kubelet integration topic while I was at it.
Still needed, to add in a separate PR: