Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project logo overlapping with other parts of nav bar #47984

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix project logo overlapping with other parts of nav bar #47984

merged 1 commit into from
Nov 20, 2024

Conversation

thisisharrsh
Copy link
Contributor

Fixes : #47889

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2024
@thisisharrsh thisisharrsh mentioned this pull request Sep 18, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e583516
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66eac2d3c8871e0008bd4bc3
😎 Deploy Preview https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisisharrsh
Copy link
Contributor Author

As discussed in the related issue, I have managed the size of the search box. Attached is the screen shot of the deployed navbar. 
Screenshot from 2024-09-18 17-49-00

@thisisharrsh thisisharrsh marked this pull request as ready for review September 18, 2024 12:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@thisisharrsh
Copy link
Contributor Author

Deployment preview: https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app/

@sftim
Copy link
Contributor

sftim commented Sep 18, 2024

/retitle Fix project logo overlapping with other parts of nav bar

@k8s-ci-robot k8s-ci-robot changed the title Logo overlaps with other navbar elements Fix project logo overlapping with other parts of nav bar Sep 18, 2024
sftim
sftim reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK but I'm wary of using pixel sizes.

Anyway, this change seems to make the site more usable. We should be cautious about accessibility implications (eg: forcing an absolute font size).

/lgtm

assets/scss/_custom.scss
box-sizing: border-box;
padding: 8px;
height: 40px;
font-size: 14px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know this is a good choice of text size?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fc1545a7ffba32b973ad29da71be7e9069da11b

@sftim
Copy link
Contributor

sftim commented Oct 2, 2024

/assign @tengqm

@nate-double-u
Copy link
Contributor

Tested on MacOS with Firefox, Chrome and Safari.

This seems to have solved the issue.

Screenshot 2024-11-19 at 2 10 49 PM Screenshot 2024-11-19 at 2 10 32 PM Screenshot 2024-11-19 at 2 10 24 PM

How do we know this is a good choice of text size?

I'm not a fan of magic numbers either, but it looks good in this case. We can revisit if needed.

/approve

@nate-double-u
Copy link
Contributor

nate-double-u commented Nov 19, 2024 •
edited
Loading

Oops, I can't approve web code updates, so an additional lgtm instead:

/lgtm

@nate-double-u
Copy link
Contributor

/approve

1 similar comment
@nate-double-u
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 794e4b3 into kubernetes:main Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holistic-developer holistic-developer holistic-developer left review comments

@sftim sftim sftim left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@salaxander salaxander Awaiting requested review from salaxander

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

Assignees

@nate-double-u nate-double-u

@tengqm tengqm

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logo overlaps with other nav bar elements when search bar is present (on Firefox)
6 participants
@thisisharrsh @sftim @k8s-ci-robot @nate-double-u @holistic-developer @tengqm