Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo overlaps with other nav bar elements when search bar is present (on Firefox) #47889

Closed
holistic-developer opened this issue Sep 11, 2024 · 13 comments · Fixed by #47984
Closed
Assignees
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@holistic-developer
Copy link

This is a Bug Report

Problem:
On Firefox the kubernetes logo overlaps with other navbar items on .../docs pages when the search bar is present.
image

Proposed Solution:
Decrease the size of the search bar.

Page to Update:
All pages using the layouts/partials/navbar.html which is mostly https://kubernetes.io/docs/

Additional Information
I used Firefox version 130 on Mac with a resolution of 1512 x 982

@holistic-developer holistic-developer added the kind/bug Categorizes issue or PR as related to a bug. label Sep 11, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 11, 2024
@holistic-developer
Copy link
Author

This might be related to #45077

@dipesh-rawat
Copy link
Member

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Sep 11, 2024
@thisisharrsh
Copy link
Contributor

/assign

@thisisharrsh
Copy link
Contributor

Facing the same issue at 1512 * 982 resolution.
Screenshot from 2024-09-12 10-24-15

@sftim
Copy link
Contributor

sftim commented Sep 15, 2024

My suggestion: drop the Case Studies section.

@thisisharrsh
Copy link
Contributor

drop the Case Studies section.

I am planning to adjust the CSS properties for the page at the given size. But I will consider your suggestion also.

@holistic-developer
Copy link
Author

holistic-developer commented Sep 17, 2024

My suggestion: drop the Case Studies section.

I would advise against that.

Here is how it is rendered in chrome at the same resolution:
image
and again on Firefox
image
So, the actual issue is the size of the search bar.

@thisisharrsh
Copy link
Contributor

Thanks @holistic-developer, for the issue rectification.

@sftim
Copy link
Contributor

sftim commented Sep 17, 2024

@holistic-developer several changes could help:

  • Managing the size of the search bar
  • Dropping the case studies section, which is no longer current
  • Improving how the top nav adapts to the available space (for example, on narrow viewports, we could have an icon rather than a bar for search; clicking the icon could take you to /search)

@katcosgrove
Copy link
Contributor

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2024
@sftim
Copy link
Contributor

sftim commented Sep 18, 2024

When I shrink the viewport to a similar width, the search form within the nav bar disappears completely. But maybe this is too dependent on details such as DPI, root element em size, etc.

@thisisharrsh
Copy link
Contributor

The issue is fixed here.

@thisisharrsh
Copy link
Contributor

  • Managing the size of the search bar

Raised the PR on this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants