Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove feature-gate NewVolumeManagerReconstruction #47564

Conversation

carlory
Copy link
Member

@carlory carlory commented Aug 19, 2024

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit dd6e72d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66c2ea03ea5cc000081e3f1b
😎 Deploy Preview https://deploy-preview-47564--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Aug 19, 2024

This should target the dev-1.32 branch rather than main.

@carlory carlory changed the base branch from main to dev-1.32 August 19, 2024 07:33
@carlory
Copy link
Member Author

carlory commented Aug 19, 2024

@tengqm updated.

@reylejano
Copy link
Member

/milestone 1.32

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Sep 3, 2024
@Shubham82
Copy link
Contributor

The changes look good to me.
/lgtm
Thanks @carlory for the fix

Merge it once upstream PR merges.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33242b029bf0f295d90fec34b32220f3a35fff86

@carlory
Copy link
Member Author

carlory commented Sep 14, 2024

/hold cancel

upstream is merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2024
@tengqm
Copy link
Contributor

tengqm commented Sep 14, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 10e98d7 into kubernetes:dev-1.32 Sep 14, 2024
6 checks passed
@carlory carlory deleted the cleanup-NewVolumeManagerReconstruction branch September 14, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants