Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup after NewVolumeManagerReconstruction is GA #126775

Merged
merged 1 commit into from
Sep 13, 2024
Merged

cleanup after NewVolumeManagerReconstruction is GA #126775

merged 1 commit into from
Sep 13, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Aug 19, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

A follow-up of #123442

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed generally available feature gate `NewVolumeManagerReconstruction`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Aug 19, 2024
@carlory
Copy link
Member Author

carlory commented Aug 19, 2024

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 19, 2024
@carlory
Copy link
Member Author

carlory commented Aug 19, 2024

/cc @jsafrane

@k8s-ci-robot k8s-ci-robot requested a review from jsafrane August 19, 2024 06:40
@carlory carlory mentioned this pull request Aug 19, 2024
Merged
@bart0sh
Copy link
Contributor

bart0sh commented Aug 19, 2024

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 19, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@carlory carlory force-pushed the cleanup-NewVolumeManagerReconstruction branch from cc62aa9 to 8d32f22 Compare September 5, 2024 02:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 5, 2024
@gnufied
Copy link
Member

gnufied commented Sep 5, 2024

/assign

@carlory
Copy link
Member Author

carlory commented Sep 6, 2024

/test pull-kubernetes-e2e-gce-storage-snapshot

@gnufied
Copy link
Member

gnufied commented Sep 13, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: acf9e2d46ecd2a4ea661932547c94351fffdec72

@gnufied
Copy link
Member

gnufied commented Sep 13, 2024

/assign @msau42

@msau42
Copy link
Member

msau42 commented Sep 13, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, gnufied, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Sep 13, 2024

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3fd2677 into kubernetes:master Sep 13, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 13, 2024
@carlory carlory deleted the cleanup-NewVolumeManagerReconstruction branch September 14, 2024 00:14
@aaron-prindle aaron-prindle mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@liggitt liggitt Awaiting requested review from liggitt

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@gnufied gnufied

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@carlory @bart0sh @gnufied @k8s-ci-robot @msau42