Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bn] Partners / index.html #46186

Merged
merged 2 commits into from
May 12, 2024
Merged

[bn] Partners / index.html #46186

merged 2 commits into from
May 12, 2024

Conversation

asem-hamid
Copy link
Contributor

@asem-hamid asem-hamid commented May 4, 2024 •
edited
Loading

Fixes Issue : #44993

updating as this PR

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2024
@k8s-ci-robot k8s-ci-robot added language/bn Issues or PRs related to Bengali language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 4, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2024
@asem-hamid
Copy link
Contributor Author

asem-hamid commented May 4, 2024 •
edited
Loading

/hold

until we update assets/scss/_custom.scss for bn version as main .

check out this PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2024
@asem-hamid asem-hamid mentioned this pull request May 8, 2024
Closed
@asem-hamid asem-hamid changed the base branch from dev-1.24-bn.1 to main May 10, 2024 12:50
@asem-hamid
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2024
@Imtiaz1234
Copy link
Member

Imtiaz1234 commented May 12, 2024 •
edited
Loading

/label tide/merge-method-squash

Imtiaz1234
Imtiaz1234 approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@Imtiaz1234 Imtiaz1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Imtiaz1234, mitul3737

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f787bd9f5646a25f53fc13a7fc7736bdcabeb75f

@Imtiaz1234
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit ec9b79d into kubernetes:main May 12, 2024
2 checks passed
@asem-hamid asem-hamid deleted the partners-/_index.html branch May 12, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Imtiaz1234 Imtiaz1234 Imtiaz1234 approved these changes

@mitul3737 mitul3737 mitul3737 approved these changes

Assignees

@Imtiaz1234 Imtiaz1234

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asem-hamid @Imtiaz1234 @k8s-ci-robot @mitul3737