Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bn] Adding example/job files in bn version #46066

Merged

Conversation

asem-hamid
Copy link
Contributor

Fixes Issue : #44993
Related PR : #45009
Tracking Issue: #31677

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 29, 2024
@asem-hamid asem-hamid changed the base branch from main to dev-1.24-bn.1 April 29, 2024 07:56
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2024
@asem-hamid
Copy link
Contributor Author

/language bn

@k8s-ci-robot k8s-ci-robot added the language/bn Issues or PRs related to Bengali language label Apr 29, 2024
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2024
Copy link
Member

@Imtiaz1234 Imtiaz1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ced62546d2bbcc77b8019a371b6d5cf8bf193c0

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the PR build preview is encountering following failures

8:57:51 AM: ERROR [bn] no Resource or Page matching "static/cncf-code-of-conduct.md*".
..
..
..
..
..
..
8:58:43 AM: ERROR [bn] "docs/concepts/workloads/pods/_index.md": "sidecar-container" is not a valid glossary term_id, see ./docs/reference/glossary/* for a full list
ERROR [bn] "docs/reference/glossary/init-container.md": "sidecar-container" is not a valid glossary term_id, see ./docs/reference/glossary/* for a full list

  • For the error "no Resource or Page matching "static/cncf-code-of-conduct.md*" the issue is that in this PR's branch adding-job-sidecar.yaml there's no "cncf-code-of-conduct.md" file inside the content/bn/community/static.

  • Regarding the error 'sidecar-container" is not a valid glossary term_id' this problem occurs because the glossary shortcode(s) (tooltip and description) relies on matching the term_id with glossary entry filename to retrieve the data. Currently, for this PR's branch asem-hamid:adding-job-sidecar.yaml the term_id in the file reads as "sidecar-container" while the file name is "sidecar-containers.md" (note the extra 's' in the end), causing the shortcode to fail in locating the necessary data.

It looks like the main kubernetes/website/dev-1.24-bn.1 branch already contains the necessary fixes. Rebasing your branch against this branch should pull in these changes, allowing the build to pass successfully. Additionally, consider pulling the latest changes from the dev-1.24-bn.1 branch into your fork (here) to ensure you have the most up-to-date codebase.

Hope this helps!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Imtiaz1234 May 6, 2024 04:10
@mitul3737
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e06535b8b074e07d81e4eff5457ee7b2466296f0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Imtiaz1234, mitul3737

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 832c481 into kubernetes:dev-1.24-bn.1 May 6, 2024
2 checks passed
@asem-hamid asem-hamid deleted the adding-job-sidecar.yaml branch May 6, 2024 04:21
@asem-hamid
Copy link
Contributor Author

@dipesh-rawat Done thank you for helping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants