-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bn] Adding example/job files in bn version #46066
[bn] Adding example/job files in bn version #46066
Conversation
/language bn |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1ced62546d2bbcc77b8019a371b6d5cf8bf193c0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the PR build preview is encountering following failures
8:57:51 AM: ERROR [bn] no Resource or Page matching "static/cncf-code-of-conduct.md*".
..
..
..
..
..
..
8:58:43 AM: ERROR [bn] "docs/concepts/workloads/pods/_index.md": "sidecar-container" is not a valid glossary term_id, see ./docs/reference/glossary/* for a full list
ERROR [bn] "docs/reference/glossary/init-container.md": "sidecar-container" is not a valid glossary term_id, see ./docs/reference/glossary/* for a full list
-
For the error
"no Resource or Page matching "static/cncf-code-of-conduct.md*"
the issue is that in this PR's branchadding-job-sidecar.yaml
there's no "cncf-code-of-conduct.md" file inside the content/bn/community/static. -
Regarding the error
'sidecar-container" is not a valid glossary term_id'
this problem occurs because the glossary shortcode(s) (tooltip and description) relies on matching theterm_id
with glossary entryfilename
to retrieve the data. Currently, for this PR's branch asem-hamid:adding-job-sidecar.yaml theterm_id
in the file reads as "sidecar-container" while the file name is "sidecar-containers.md"
(note the extra 's' in the end), causing the shortcode to fail in locating the necessary data.
It looks like the main kubernetes/website/dev-1.24-bn.1 branch already contains the necessary fixes. Rebasing your branch against this branch should pull in these changes, allowing the build to pass successfully. Additionally, consider pulling the latest changes from the dev-1.24-bn.1 branch into your fork (here) to ensure you have the most up-to-date codebase.
Hope this helps!
…into adding-job-sidecar.yaml
/lgtm |
LGTM label has been added. Git tree hash: e06535b8b074e07d81e4eff5457ee7b2466296f0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Imtiaz1234, mitul3737 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dipesh-rawat Done thank you for helping |
Fixes Issue : #44993
Related PR : #45009
Tracking Issue: #31677