Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a blog post about QueueingHint #43686
Add a blog post about QueueingHint #43686
Changes from 4 commits
2701c1a
ba18bc4
0c73dc3
dc5d233
1d2f831
8d9a069
3cdf93b
430c9f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that for beta, or maybe GA, there is a document about how to use this in your custom scheduler that extends kube-scheduler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, that's beyond the scope of user docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.
If this isn't something we'll document: why is it important enough to announce in a blog article?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think how to use is too much, while an overview is worthwhile for everyone.
Not only QueueingHint, but the scheduling framework in general is on the border between internal and user-facing feature. It's a very fundamental design and it could be important not only for custom-scheduler developers but also for everyone to understand how K8s scheduling works in general. So, we have a doc explaining an overview of the scheduling framework and each interface: https://kubernetes.io/docs/concepts/scheduling-eviction/scheduling-framework/
But, OTOH, we don't explain how to actually implement each interface in detail (e.g., Filter can return these statuses, etc), while the actual interfaces have comments explaining such detail (so, does QueueingHint). This is how the scheduling framework is explained currently, and IMO it's a good balance - If we explain everything about each interface in K8s doc, it'd be too huge to maintain and could be rotten very easily. Comments in source code could be easily maintained with the implementation.
Talking about this blog post, it's also an overview of what QueueingHint does (it's like this doc, but a bit more detailed overview), but we deliberately don't go into an implementation detail or how the users can implement their QueueingHint for their custom schedulers.