Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blog post about QueueingHint #43686

Closed
wants to merge 8 commits into from
Closed

Add a blog post about QueueingHint #43686

wants to merge 8 commits into from

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Oct 25, 2023 •
edited by sftim
Loading

This is a placeholder PR for blog post of QueueingHint.
kubernetes/enhancements#4247

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 430c9f3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/657a572accf99400081ffb01
😎 Deploy Preview https://deploy-preview-43686--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aj11anuj
aj11anuj reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty?

@dipesh-rawat
Copy link
Member

/retitle [WIP] Add a blog post about QueueingHint

@k8s-ci-robot k8s-ci-robot changed the title blog post: QueueingHint [WIP] Add a blog post about QueueingHint Oct 25, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023
@dipesh-rawat
Copy link
Member

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 25, 2023
sftim
sftim reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
pending assignment of publication date

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2023
@sanposhiho sanposhiho mentioned this pull request Oct 30, 2023
Open
14 tasks
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
@sanposhiho sanposhiho changed the title [WIP] Add a blog post about QueueingHint Add a blog post about QueueingHint Nov 13, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@sanposhiho
Copy link
Member Author

/cc @alculquicondor

For the technical review from SIG-Scheduling.

alculquicondor
alculquicondor reviewed Nov 13, 2023
View reviewed changes
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please use SVG for the figures - these will have a wide audience and we'd like localization teams to be able to edit the text. Contributors often use Inkscape, but any tool will do.
You can also use Mermaid for all or part of the diagram

It's nice if the most obvious color in the figures is Kubernetes' blue and the second most obvious is solid black or Kubernetes' gray.

Two pages that might help:

content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated
@@ -0,0 +1,99 @@
---
layout: blog
title: "Kubernetes v1.28: QueueingHint brings a new possibility to optimize our scheduling"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.29 now, please. Also - until we change the style guide: Title Case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've marked this conversation as “not resolved” because the feedback is still applicable.

content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-11-xx-scheduler-queueinghint/index.md Outdated Show resolved Hide resolved
@krol3
Copy link
Contributor

krol3 commented Nov 15, 2023

Hi @sanposhiho! here Communication Team 1.29, the deadline to the feature blog be ready to review is this Friday, Nov 17th, the proposal publish date will be Dec 13th. cc: @a-mccarthy @kcmartin @James-Quigley

@sanposhiho
Copy link
Member Author

@krol3 This PR is already ready to review, although I couldn't get time to address the comments due to huge TODOs made while attending Kubecon. 😓
I'll address them by today or tomorrow at the latest.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2023
@sftim
Copy link
Contributor

sftim commented Dec 1, 2023

/lgtm cancel
/approve cancel

Requires new date

@sanposhiho
Copy link
Member Author

The date is updated.

@sftim
Copy link
Contributor

sftim commented Dec 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae88236d6d49bcdd3c767f27319fcc58070ec48e

@sftim
Copy link
Contributor

sftim commented Dec 3, 2023

I've (manually) retriggered a build at Netlify.

@sftim
Copy link
Contributor

sftim commented Dec 5, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@sanposhiho sanposhiho mentioned this pull request Dec 13, 2023
Open
@reylejano
Copy link
Member

Manually re-triggered the deploy and failed during the build with

12:49:53 PM: Failed during stage "building site": Command did not finish within the time limit
12:49:53 PM: Execution timed out after 31m40.001483322s
12:49:53 PM: Failing build: Failed to build site

@alculquicondor
Copy link
Member

/hold

The feature itself was just disabled due to multiple regressions kubernetes/kubernetes#122289, so perhaps it's best to withdraw from this post for now.

@sanposhiho
Copy link
Member Author

it's best to withdraw from this post for now.

+1 for this. We can publish when we re-enable the feature gate.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim December 14, 2023 01:15
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sftim
Copy link
Contributor

sftim commented Dec 14, 2023

/approve cancel

Given #43686 (comment)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2024
@divya-mohan0209
Copy link
Contributor

@alculquicondor @sanposhiho : Please advise what needs to be done with this PR. Is there any ETA for the feature gate to be re-enabled?

@sanposhiho
Copy link
Member Author

sanposhiho commented Apr 1, 2024 •
edited
Loading

We can say the estimated timeline is the next release (1.31) (but honestly not very sure because there are many pending PRs we need to ask other people for the review. So, depends on people's bandwidth.)
If you want, we're ok to just close this PR for now as we can reopen the PR anytime.

@divya-mohan0209
Copy link
Contributor

@sanposhiho I'd recommend revisiting this PR whenever we're sure the feature gate is re-enabled. Given that we can reopen this PR whenever we do that, I'll be closing it off now.
/close

@k8s-ci-robot
Copy link
Contributor

@divya-mohan0209: Closed this PR.

In response to this:

@sanposhiho I'd recommend revisiting this PR whenever we're sure the feature gate is re-enabled. Given that we can reopen this PR whenever we do that, I'll be closing it off now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanposhiho sanposhiho mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj11anuj aj11anuj aj11anuj left review comments

@reylejano reylejano reylejano left review comments

@kcmartin kcmartin kcmartin left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Planned
SIG Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.