Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document snag with Secrets, stringData, and server-side apply #43668

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Document snag with Secrets, stringData, and server-side apply #43668

merged 1 commit into from
Dec 8, 2023

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Oct 24, 2023

supplyment of #42631

try to fix: #42603

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 920a68b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65376a8d4b61e40008eac9ef
😎 Deploy Preview https://deploy-preview-43668--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 24, 2023

/retitle Document snag with Secrets, stringData, and server-side apply

@k8s-ci-robot k8s-ci-robot changed the title Part 2 - Document snag with stringData and server-side apply Document snag with Secrets, stringData, and server-side apply Oct 24, 2023
sftim
sftim reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Even better: outline what the problem is and document (in one place) what you might do instead (ie: data).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33ed8e8c41a753c7b2d4a6986b364c09a2ad3356

divya-mohan0209
divya-mohan0209 reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit db82373 into kubernetes:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document snag with stringData and server-side apply
4 participants
@pegasas @sftim @k8s-ci-robot @divya-mohan0209