Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document snag with stringData and server-side apply #42631

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Aug 19, 2023

This is a Feature Request

What would you like to be added

Why is this needed kubernetes/kubernetes#118519 etc

Comments /language en /kind feature /triage accepted /priority backlog

I only finds 2 reference in these 4 files.

Feel free to correct me if I am wrong.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 19, 2023
@k8s-ci-robot k8s-ci-robot requested a review from reylejano August 19, 2023 03:43
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2023
@pegasas
Copy link
Contributor Author

pegasas commented Aug 19, 2023

try to fix: #42603

@netlify
Copy link

netlify bot commented Aug 19, 2023

Pull request preview available for checking

Name Link
🔨 Latest commit cf83760
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652405eb3db6d80008135eb6
😎 Deploy Preview https://deploy-preview-42631--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pegasas pegasas marked this pull request as ready for review August 23, 2023 02:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59c9b11e38412649f97812fefafd667dad5ec727

@k8s-ci-robot k8s-ci-robot merged commit f9365c8 into kubernetes:main Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants