Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove caution indentations in tabs of install-kubeadm.md #43432

Closed
wants to merge 1 commit into from
Closed

remove caution indentations in tabs of install-kubeadm.md #43432

wants to merge 1 commit into from

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Oct 11, 2023 •
edited
Loading

Revert the caution indentations in tabs by following #43425 (comment).

cc @afbjorklund

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 31cdc09
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65266faba33a6a0008bae256
😎 Deploy Preview https://deploy-preview-43432--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@windsonsea windsonsea mentioned this pull request Oct 11, 2023
Merged
@tengqm
Copy link
Contributor

tengqm commented Oct 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 04d589b5701583ad86d753d2d98ef8060ea97cdf

@windsonsea
Copy link
Member Author

This change was included in #43458, so this will be closed, thanks.

@windsonsea windsonsea closed this Oct 13, 2023
@windsonsea windsonsea deleted the tabsy branch August 20, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@tengqm tengqm

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@windsonsea @k8s-ci-robot @tengqm @sftim