-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up /kubeadm/install-kubeadm.md #43425
Conversation
/kind cleanup |
LGTM label has been added. Git tree hash: 5363f682f0d4d71fe09076fc83bcd8fa7b170f51
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This commit broke the rendering, by indenting the "caution" macro (thereby destroying the install tabs) So now the tarball instructions are repeated, also for the package installations. These tabs are confusing... |
Sorry, will fix it soon. |
If you are cleaning up the page, there is an issue with the "these instructions are for k8s 1.28" indented under SELinux
These lines should probably be swapped around ? |
Hi @afbjorklund , should we open an issue if the procedure requires update? I am unsure and have not verified whether the steps and commands are correct or not. |
Sure, it is a separate issue |
I'm unaware of these limitations of the |
Linking to the content (in a tab) is also harder |
Performed actions below: