Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up /kubeadm/install-kubeadm.md #43425

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

windsonsea
Copy link
Member

Performed actions below:

  • Remove redundant blank lines and add a blank line after a heading
  • Tweak long lines
  • Provide a consistent indentations for list in tabs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm October 11, 2023 01:17
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 11, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 11, 2023

/kind cleanup
/lgtm
/approve
Thanks.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5363f682f0d4d71fe09076fc83bcd8fa7b170f51

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b4b808
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6525f7866a98800008cd93a7
😎 Deploy Preview https://deploy-preview-43425--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot merged commit f53ca06 into kubernetes:main Oct 11, 2023
3 checks passed
@windsonsea windsonsea deleted the admyh branch October 11, 2023 01:40
@afbjorklund
Copy link

afbjorklund commented Oct 11, 2023

@windsonsea :

This commit broke the rendering, by indenting the "caution" macro (thereby destroying the install tabs)

So now the tarball instructions are repeated, also for the package installations. These tabs are confusing...

@windsonsea
Copy link
Member Author

Sorry, will fix it soon.

@afbjorklund
Copy link

afbjorklund commented Oct 11, 2023

If you are cleaning up the page, there is an issue with the "these instructions are for k8s 1.28" indented under SELinux

Red Hat-based distributions

  1. Set SELinux to permissive mode:

These instructions are for Kubernetes 1.28.

These lines should probably be swapped around ?

@windsonsea
Copy link
Member Author

windsonsea commented Oct 11, 2023

Hi @afbjorklund , should we open an issue if the procedure requires update? I am unsure and have not verified whether the steps and commands are correct or not.

@afbjorklund
Copy link

Sure, it is a separate issue

@tengqm
Copy link
Contributor

tengqm commented Oct 11, 2023

I'm unaware of these limitations of the tabs struct, though I really dislike it.
When I try print the docs, tabs doesn't expand. Tabs are only making the pages fancy,
and they sometimes help shorten the page for visual scanning.
Sorry for having merged this in a premature state.

@afbjorklund
Copy link

Linking to the content (in a tab) is also harder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants