Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the reference link for 'secret permissions with default mode' #43402

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fixed the reference link for 'secret permissions with default mode' #43402

merged 1 commit into from
Oct 10, 2023

Conversation

thisisharrsh
Copy link
Contributor

Fixes: #43253

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from marosset October 10, 2023 07:21
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 10, 2023
@thisisharrsh
Copy link
Contributor Author

As given in the #38083, the commit (line 195) shows the heading is changed to Set POSIX permissions for Secret Keys from Secret file permissions.

@thisisharrsh thisisharrsh mentioned this pull request Oct 10, 2023
Closed
@netlify
Copy link

netlify bot commented Oct 10, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f21893
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6524fb724245a30008e32bb4
😎 Deploy Preview https://deploy-preview-43402--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
dipesh-rawat
dipesh-rawat reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix and explanation in #43402 (comment)!
/lgtm

Preview Page

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa97c1e45fb833940c25ca76d7041a2bb4f67cbe

@k8s-ci-robot k8s-ci-robot merged commit d3f6c70 into kubernetes:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@aravindhp aravindhp Awaiting requested review from aravindhp

@marosset marosset Awaiting requested review from marosset

Assignees

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect link for secret permissions with DefaultMode
4 participants
@thisisharrsh @tengqm @k8s-ci-robot @dipesh-rawat