Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect link for secret permissions with DefaultMode #43253

Closed
thisisharrsh opened this issue Sep 29, 2023 · 5 comments · Fixed by #43402
Closed

Incorrect link for secret permissions with DefaultMode #43253

thisisharrsh opened this issue Sep 29, 2023 · 5 comments · Fixed by #43402
Assignees
@thisisharrsh
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@thisisharrsh
Copy link
Contributor

This is a Bug Report

Problem: The link for secret permissions with DefaultMode under persistent storage in Windows storage is incorrect. It is redirecting to the https://kubernetes.io/docs/concepts/configuration/secret/#secret-files-permissions instead of that it should redirect to the https://kubernetes.io/docs/tasks/inject-data-application/distribute-credentials-secure/#set-posix-permissions-for-secret-keys.

As given in the PR, the commit (line 195) shows the heading is changed to Set POSIX permissions for Secret Keys from Secret file permissions.

Proposed Solution: secret permissions with DefaultMode should redirect to the https://kubernetes.io/docs/tasks/inject-data-application/distribute-credentials-secure/#set-posix-permissions-for-secret-keys instead of https://kubernetes.io/docs/concepts/configuration/secret/#secret-files-permissions

Page to Update: https://kubernetes.io/docs/concepts/storage/windows-storage/
@thisisharrsh thisisharrsh added the kind/bug Categorizes issue or PR as related to a bug. label Sep 29, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 29, 2023
@thisisharrsh
Copy link
Contributor Author

/language en
/sig docs
/sig storage

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Sep 29, 2023
@thisisharrsh
Copy link
Contributor Author

I would like to work on it.
/assign

@thisisharrsh thisisharrsh removed their assignment Oct 4, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2023

/triage accepted
A fixup/clarification is welcome.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@thisisharrsh
Copy link
Contributor Author

/assign

@thisisharrsh thisisharrsh mentioned this issue Oct 10, 2023
Merged
@thisisharrsh
Copy link
Contributor Author

The issue is fixed here: #43402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisharrsh thisisharrsh

Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed the reference link for 'secret permissions with default mode' thisisharrsh/website
3 participants
@tengqm @k8s-ci-robot @thisisharrsh