Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added secret keyword to kubectl-command.html file #41053

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

nitishfy
Copy link
Member

Fix: #35577

@k8s-ci-robot k8s-ci-robot requested a review from natalisucks May 10, 2023 04:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from reylejano May 10, 2023 04:58
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2023
@netlify
Copy link

netlify bot commented May 10, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9afdd65
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/645b248beff41f0008b4a2b5
😎 Deploy Preview https://deploy-preview-41053--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@able8
Copy link
Contributor

able8 commented May 10, 2023

Hi, why you re-open this PR, i can see the old PR #35586

See the previout comments:
#35586 (comment)
This file (website/static/docs/reference/generated/kubectl/kubectl-commands.html) is auto-generated, please don't fix it here.

#35586 (comment)
FWIW, the upstream source code is here:
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/create/create_secret_tls.go#L93

@Ritikaa96
Copy link
Contributor

Ritikaa96 commented Sep 19, 2023

Hi @nitishfy , Are you still working on this PR? '
If yes, then I'll suggest you first make a change here

Then after the PR is merged, you can raise for a change in the website. Please note that this file is auto-generated, so on sync up even if you change it here without a change in the source file the text will be reverted.

@Ritikaa96
Copy link
Contributor

Ritikaa96 commented Sep 19, 2023

If you are still confused about the repository, first raise the pr request for a change in the source file in kubernetes/kubernetes .
Also, confirm here if you are still working on this Issue.
Maybe this link will be able to help in understanding and testing the change.

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

/lgtm
/approve
as a workaround.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e9b6dd66cfe94db3cec4eef5e25a4a2712835320

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5b3dd1a into kubernetes:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in kubectl-commands.html file
5 participants