Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in kubectl-commands.html file #35577

Closed
alfein opened this issue Jul 30, 2022 · 9 comments · Fixed by #41053
Closed

Issue in kubectl-commands.html file #35577

alfein opened this issue Jul 30, 2022 · 9 comments · Fixed by #41053
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@alfein
Copy link

alfein commented Jul 30, 2022

Hello team.

Recently I noticed that this page: https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#-em-secret-tls-em- shows wrong command. Instead of

kubectl create tls NAME --cert=path/to/cert/file --key=path/to/key/file [--dry-run=server|client|none]

it should be

kubectl create secret tls NAME --cert=path/to/cert/file --key=path/to/key/file [--dry-run=server|client|none]

I believe the fix should go into this file https://github.com/kubernetes/website/blob/9ba644e361972562c5f3d39b92dedc8128c439b2/static/docs/reference/generated/kubectl/kubectl-commands.html

Please review.

Thank you

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 30, 2022
@nitishfy
Copy link
Member

/assign

@jihoon-seo
Copy link
Member

  • kubectl create secret
    • kubectl create docker-registry -> kubectl create secret docker-registry
    • kubectl create generic -> kubectl create secret generic
    • kubectl create tls -> kubectl create secret tls
  • kubectl create service
    • kubectl create clusterip -> kubectl create service clusterip
    • kubectl create externalname -> kubectl create service externalname
    • kubectl create loadbalancer -> kubectl create service loadbalancer
    • kubectl create nodeport -> kubectl create service nodeport

Also see this:

#35586 (comment)

This file (website/static/docs/reference/generated/kubectl/kubectl-commands.html) is auto-generated, please don't fix it here.

#35586 (comment)

FWIW, the upstream source code is here:
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/create/create_secret_tls.go#L93

@dipankardas011
Copy link
Contributor

dipankardas011 commented Aug 1, 2022

@jihoon-seo should this issue and its corresponding PR be closed?

@jihoon-seo
Copy link
Member

@dipankardas011
@nitishkumar06 closed his prior PR, and opened another one in k/k.

IMO it would be good to keep this issue open until the error in K8s Docs has been resolved. 😊

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 1, 2022
@dipankardas011
Copy link
Contributor

@dipankardas011
@nitishkumar06 closed his prior PR, and opened another one in k/k.

IMO it would be good to keep this issue open until the error in K8s Docs has been resolved. 😊

/kind bug

Okay 👍

@mehabhalodiya
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 13, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2022
@nitishfy
Copy link
Member

@jihoon-seo Should the PR be opened in Kuberenetes/website?

@vaibhav2107
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
8 participants