Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document plugin resolution as subcommand for builtin commands #39969

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

ardaguclu
Copy link
Member

This PR adds document for the alpha stage of kubernetes/enhancements#3638

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Mar 13, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2023
@sftim
Copy link
Contributor

sftim commented Mar 28, 2023

I think content/en/docs/reference/kubectl/kubectl.md is automatically generated; if that's right, then you don't need to send in this change. However, if there's no other documentation, will people know that they could try using it?

@ardaguclu
Copy link
Member Author

I think content/en/docs/reference/kubectl/kubectl.md is automatically generated; if that's right, then you don't need to send in this change. However, if there's no other documentation, will people know that they could try using it?

Thanks @sftim. Shouldn't I add this new environment variable into somewhere to feed this auto generated page content/en/docs/reference/kubectl/kubectl.md?

@LukeMwila
Copy link

LukeMwila commented Apr 4, 2023

Hey @sftim @ardaguclu, just following up on the changes to content/en/docs/reference/kubectl/kubectl.md. The docs PRs have to be merged by end of today.

@ardaguclu
Copy link
Member Author

I mimicked the same place in this PR #37788. If there is any other place should be added, I gladly can add there.

@sftim
Copy link
Contributor

sftim commented Apr 4, 2023

Hey @sftim @ardaguclu, just following up on the changes to content/en/docs/reference/kubectl/kubectl.md. The docs PRs have to be merged by end of today.

I checked https://github.com/kubernetes/sig-release/tree/master/releases/release-1.27
The docs PRs have to be ready to merge today. Merges should be done by the start of the 10th of April.

I don't know whether SIG Docs has capacity to get all the pending 1.27 PRs reviewed today. My guess is no.

@LukeMwila
Copy link

LukeMwila commented Apr 4, 2023

Hey @sftim @ardaguclu, just following up on the changes to content/en/docs/reference/kubectl/kubectl.md. The docs PRs have to be merged by end of today.

I checked https://github.com/kubernetes/sig-release/tree/master/releases/release-1.27 The docs PRs have to be ready to merge today. Merges should be done by the start of the 10th of April.

I don't know whether SIG Docs has capacity to get all the pending 1.27 PRs reviewed today. My guess is no.

Thanks for the response @sftim, and sorry for the confusion. I meant ready to merge.

@LukeMwila
Copy link

/approve

@LukeMwila
Copy link

I mimicked the same place in this PR #37788. If there is any other place should be added, I gladly can add there.

I had a look at the previous PR that you referred to. Thanks.

@reylejano
Copy link
Member

This will be overwritten when the kubectl reference docs are generated

@divya-mohan0209
Copy link
Contributor

I'm happy to lgtm this change so that this is reflected in the 1.27 change log. However, this will be overwritten during the reference doc generation & I'd advise @ardaguclu to refer to this page for amending the correct files & getting the relevant changes reflected.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea53ac9e142a5906fd0bb6c12492d366e7025334

@divya-mohan0209
Copy link
Contributor

@sftim / @reylejano / @tengqm : Please advise if the information I've supplemented wrt the guide is incorrect.

@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2023

/approve

The auto-generated contents is here: static/docs/reference/generated/kubectl/

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LukeMwila, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit e1c71e3 into kubernetes:dev-1.27 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants