-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document plugin resolution as subcommand for builtin commands #39969
Conversation
I think |
Thanks @sftim. Shouldn't I add this new environment variable into somewhere to feed this auto generated page content/en/docs/reference/kubectl/kubectl.md? |
Hey @sftim @ardaguclu, just following up on the changes to |
I mimicked the same place in this PR #37788. If there is any other place should be added, I gladly can add there. |
I checked https://github.com/kubernetes/sig-release/tree/master/releases/release-1.27 I don't know whether SIG Docs has capacity to get all the pending 1.27 PRs reviewed today. My guess is no. |
Thanks for the response @sftim, and sorry for the confusion. I meant ready to merge. |
/approve |
I had a look at the previous PR that you referred to. Thanks. |
This will be overwritten when the kubectl reference docs are generated |
I'm happy to lgtm this change so that this is reflected in the 1.27 change log. However, this will be overwritten during the reference doc generation & I'd advise @ardaguclu to refer to this page for amending the correct files & getting the relevant changes reflected. /lgtm |
LGTM label has been added. Git tree hash: ea53ac9e142a5906fd0bb6c12492d366e7025334
|
@sftim / @reylejano / @tengqm : Please advise if the information I've supplemented wrt the guide is incorrect. |
/approve The auto-generated contents is here: static/docs/reference/generated/kubectl/ |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LukeMwila, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds document for the alpha stage of kubernetes/enhancements#3638