Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document kubectl plugin resolution for non-shadowing subcommands #39800

Closed
wants to merge 1 commit into from
Closed

Document kubectl plugin resolution for non-shadowing subcommands #39800

wants to merge 1 commit into from

Conversation

ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Mar 6, 2023 •
edited
Loading

This PR adds document for the alpha stage of kubernetes/enhancements#3638

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from reylejano March 6, 2023 05:27
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 6, 2023 05:27
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 6, 2023
@ardaguclu ardaguclu marked this pull request as draft March 6, 2023 05:27
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
@netlify
Copy link

netlify bot commented Mar 6, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1cbca5c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640ac0d2426d2c000834b98e
😎 Deploy Preview https://deploy-preview-39800--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim sftim changed the title KEP-3638 placeholder commit for alpha [WIP] Document kubectl plugin resolution for non-shadowing subcommands Mar 6, 2023
@sftim
Copy link
Contributor

sftim commented Mar 6, 2023

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Mar 6, 2023
@sftim sftim mentioned this pull request Mar 6, 2023
Closed
8 tasks
@ardaguclu ardaguclu marked this pull request as ready for review March 6, 2023 13:35
@k8s-ci-robot k8s-ci-robot requested a review from bradtopol March 6, 2023 13:35
@ardaguclu ardaguclu changed the title [WIP] Document kubectl plugin resolution for non-shadowing subcommands Document kubectl plugin resolution for non-shadowing subcommands Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
@ardaguclu ardaguclu changed the title Document kubectl plugin resolution for non-shadowing subcommands WIP: Document kubectl plugin resolution for non-shadowing subcommands Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2023
@ardaguclu ardaguclu changed the title WIP: Document kubectl plugin resolution for non-shadowing subcommands Document kubectl plugin resolution for non-shadowing subcommands Mar 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@ardaguclu
Copy link
Member Author

I'm closing this PR in favor of #39969. Because correct target branch is not main, it is dev-1.27.

/close

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: Closed this PR.

In response to this:

I'm closing this PR in favor of #39969. Because correct target branch is not main, it is dev-1.27.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano Awaiting requested review from reylejano

@sftim sftim Awaiting requested review from sftim

@bradtopol bradtopol Awaiting requested review from bradtopol

Assignees
No one assigned
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardaguclu @k8s-ci-robot @sftim