Revise Service concept, part 14 #39499
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
| A Service in Kubernetes is a REST object (just as a Pod or a ConfigMap is an object | ||
| that you can access as a resource in the Kubernetes HTTP API. | ||
| You can use the HTTP API to create a new Service instance, to apply changes to an | ||
| existing Service, or to request deletion. |
There was a problem hiding this comment.
| A Service in Kubernetes is a REST object (just as a Pod or a ConfigMap is an object | |
| that you can access as a resource in the Kubernetes HTTP API. | |
| You can use the HTTP API to create a new Service instance, to apply changes to an | |
| existing Service, or to request deletion. | |
| A Service, similar to Pods and ConfigMaps, is an object | |
| that you can access as a resource in the Kubernetes HTTP API. | |
| You can use the HTTP API to create a new Service, to apply changes to an | |
| existing Service, or to request deletion. |
Removed "instance" - stick to "object" or "resource".
Also, is mentioning HTTP API necessary in both sentences?
There was a problem hiding this comment.
I'm wary of comparing Service (singular) with Pods and ConfigMaps (both plural). I also want to avoid starting the sentence with “Service” because I want the emphasis that the initial capital provides.
There was a problem hiding this comment.
Maybe "similar to a Pod or a ConfigMap," ?
| @@ -94,12 +97,12 @@ spec: | |||
| targetPort: 9376 | |||
| ``` | |||
|
|
|||
| This specification creates a new Service object named "my-service", which | |||
| targets TCP port 9376 on any Pod with the `app.kubernetes.io/name=MyApp` label. | |||
| That manifest creates a new Service named "my-service", which | |||
There was a problem hiding this comment.
| That manifest creates a new Service named "my-service", which | |
| This manifest creates a new Service named "my-service", which |
"This" feels like it more organically refers to "The preceding manifest"
sftim
force-pushed
the
20230216_service_update_part_14
branch
3 times, most recently
from
375fe3a to
98c7d48
Compare
Co-authored-by: Shannon Kularathna <[email protected]>
sftim
force-pushed
the
20230216_service_update_part_14
branch
from
98c7d48 to
c322487
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Co-authored-by: Shannon Kularathna <[email protected]>
|
Page preview: https://deploy-preview-39499--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/service/ Imo, this PR improves the service concept page /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2fae5fe9c8379916c2f3919c2b30ba5d963541a2
|
These are some miscellaneous changes that I recommend making but that don't really fit in to any other PR.
preview / original
Split out from #30817
View that PR to see these changes in context.
These changes come after what you can see in #38562, and should not conflict with the changes I'm recommending in #38563.