Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise introduction to Service page #38562

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Revise introduction to Service page #38562

merged 1 commit into from
Feb 21, 2023

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 19, 2022 •
edited
Loading

Split out from #30817
View that PR to see these changes in context.

PR #38563 has changes that come in where this PR ends.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Dec 19, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2022
@sftim sftim mentioned this pull request Dec 19, 2022
Closed
@netlify
Copy link

netlify bot commented Dec 19, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 72b9f09
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63ee893bab53320007281153
😎 Deploy Preview https://deploy-preview-38562--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sftim sftim mentioned this pull request Dec 19, 2022
Merged
tengqm
tengqm reviewed Dec 22, 2022
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.
The two suggestions left are not blocking ones.

content/en/docs/concepts/services-networking/service.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/service.md Show resolved Hide resolved
@sftim sftim force-pushed the 20221219_revise_service_concept_introduction branch 2 times, most recently from e20f27b to 032c9a5 Compare January 25, 2023 00:02
@sftim
Copy link
Contributor Author

sftim commented Jan 25, 2023

I reworded to avoid mentioning horizontal scaling.

@sftim sftim mentioned this pull request Feb 16, 2023
Merged
@sftim sftim force-pushed the 20221219_revise_service_concept_introduction branch from 032c9a5 to 72b9f09 Compare February 16, 2023 19:51
@sftim
Copy link
Contributor Author

sftim commented Feb 16, 2023

How about this wording?

@tengqm
Copy link
Contributor

tengqm commented Feb 17, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44bb198ed20ecb4cdcd5c7535e2e7afcafa11a2d

reylejano
reylejano reviewed Feb 21, 2023
View reviewed changes
content/en/docs/concepts/services-networking/service.md
Each Pod gets its own IP address, however in a Deployment, the set of Pods
running in one moment in time could be different from
the set of Pods running that application a moment later.
Each Pod gets its own IP address (Kubernetes expects network plugins to ensure this).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nit: a link to the network plugins page may be helpful to new users

Suggested change
Each Pod gets its own IP address (Kubernetes expects network plugins to ensure this).
Each Pod gets its own IP address (Kubernetes expects [network plugins](/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/) to ensure this).

@reylejano
Copy link
Member

The proposed updates in this PR improve the Services concepts page easier to understand for new and experienced users
Thank you for the update
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 903da02 into kubernetes:main Feb 21, 2023
@sftim sftim deleted the 20221219_revise_service_concept_introduction branch September 23, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano reylejano left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@tengqm tengqm tengqm left review comments

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sftim @tengqm @k8s-ci-robot @reylejano @divya-mohan0209