Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #3895

Merged
merged 2 commits into from
May 30, 2017
Merged

fix typo #3895

merged 2 commits into from
May 30, 2017

Conversation

wangxunbo
Copy link

@wangxunbo wangxunbo commented May 25, 2017 •
edited by k8s-reviewable
Loading

I Created a deployment yaml file tomcatdp.yaml， and did not set the .spec.strategy，then run
kubectl create -f tomcatdp.yaml,
and then run
kubectl get deployment tomcat-deployment -o yaml,
the tomcat-deployment is the name of the deployment,found that the MaxUnavailable and MaxSurge default value is 25%

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is Reviewable

fix typo
3adefbf 
I Created a  deployment yaml file tomcatdp.yaml， and did not set the .spec.strategy，then run 
kubectl create -f tomcatdp.yaml,
and then run 
kubectl get deployment tomcat-deployment -o yaml,
the tomcat-deployment is the name of the deployment,found that the MaxUnavailable and MaxSurge default value is 25%
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 25, 2017
@wangxunbo
Copy link
Author

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 26, 2017
@chenopis chenopis self-assigned this May 26, 2017
@chenopis chenopis requested a review from 0xmichalis May 26, 2017 17:28
@jonpulsifer
Copy link

kubernetes > 1.6.0 introduces new deployment defaults in apps/v1beta1

The embedded nginx-deployment.yaml uses apiVersion: apps/v1beta1
https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/concepts/workloads/controllers/nginx-deployment.yaml#L1

apps/v1beta1 defaults in kubernetes master:
https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/apps/v1beta1/defaults.go#L83-L92

Based on this [and the ref'd PRs below] they should be bumped to 25%

cc @chenopis ¯\_(ツ)_/¯
ref #3814
ref kubernetes/kubernetes#39683

@chenopis
Copy link
Contributor

@jonpulsifer Ok, thanks for the context.

@chenopis chenopis removed the request for review from 0xmichalis May 30, 2017 18:47
@chenopis chenopis merged commit ee92eaf into kubernetes:master May 30, 2017
chenopis added a commit that referenced this pull request May 30, 2017
@chenopis
Merge branch 'master' of https://github.com/kubernetes/kubernetes.git…
cca652b 
…hub.io into release-1.7

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  fix typo (#3895)
  add unit of --ttl duration (#3915)
  Fixes broken links
  Prototype of custom description meta tags. (#3928)
  Site URL for canonical URLs. (#3927)
  Warn about implications on selector updates
  grammar patch to #3922 (#3923)
  add calico to the table of solution
  Minor grammatical change
chenopis added a commit that referenced this pull request May 30, 2017
@chenopis
Merge branch 'master' of https://github.com/kubernetes/kubernetes.git…
153e91d 
…hub.io into release-1.6

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (627 commits)
  Fixed a minor mistake
  docs/concepts/policy/pod-security-policy.md: add projected to list of allowed types.
  Init container exists beta in 1.6.
  fix typo (#3895)
  add unit of --ttl duration (#3915)
  Fixes broken links
  Prototype of custom description meta tags. (#3928)
  Site URL for canonical URLs. (#3927)
  Warn about implications on selector updates
  grammar patch to #3922 (#3923)
  add calico to the table of solution
  Minor grammatical change
  Add deprecation tag (#3922)
  Fix sentence
  Minor grammatical correction
  Remove beta as K8s support on Bluemix Container Service is live
  Fix some output
  replace REASON with STATUS
  column IP is missed
  replace kubectl.sh with kubectl
  ...

# Conflicts:
#	docs/tasks/debug-application-cluster/logging-elasticsearch-kibana.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chenopis chenopis

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangxunbo @k8s-ci-robot @jonpulsifer @chenopis