apps/v1beta1 is not valid

[campoy]

Replacing it with extensions/v1beta1 which actually works

Found this file from this document:
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

---

This change is 

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[foxish]

apps/v1beta1 is correct, and newer. https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md#deployment-2

[chenopis]

@foxish So can I close this PR?

[campoy]

When was this changed?

It still fails for me with this kubectl version:

Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.2", GitCommit:"477efc3cbe6a7effca06bd1452fa356e2201e1ee", GitTreeState:"clean", BuildDate:"2017-04-19T20:33:11Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.7", GitCommit:"8eb75a5810cba92ccad845ca360cf924f2385881", GitTreeState:"clean", BuildDate:"2017-04-27T09:42:05Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}

Trying to create a deployment using apps/v1beta1 gives:

error: error validating "kubernetes.yaml": error validating data: couldn't find type: v1beta1.Deployment; if you choose to ignore these errors, turn validation off with --validate=false

[foxish]

The server version needs to be 1.6 or higher for it to work. kubernetes/kubernetes#39683 added the new apps/v1beta1.Deployment which will become the default eventually and we'll deprecate extensions/v1beta1.Deployment by the year end. See kubernetes/kubernetes#43214

[foxish]

In the absence of versioned docs (as opposed to docs that reflect the latest version only), we can't make this change. cc @janetkuo @kubernetes/sig-apps-misc

[0xmichalis]

Yeah, we really need versioned docs.

[campoy]

Agreed, versioned docs are essential here.

In the meanwhile, could we add a note about how in previous versions the value is different?
This was very confusing for me

[foxish]

I think a note makes total sense! @campoy, can you modify your PR to add that? Also I think you'll need to sign the CLA. It can be similar to how the node controller specifies pre-1.5 behavior. Thanks!
@chenopis, In the long term, perhaps we should come up with a standard way to call out such changes in docs.

[0xmichalis]

@kubernetes/sig-docs-maintainers is there any discussion somewhere re versioned docs?

[campoy]

PTAL

[campoy]

I am authorized to contribute, as a Google employee

[foxish]

I was thinking more along specifying the constraint in the text description surrounding the YAML. @chenopis WDYT of comments inline in the YAML itself?

[campoy]

Well, I don't know from how many places this specific file is embedded.
If it's only one I could easily add a note there

[chenopis]

Yeah, I like this solution. YAML comments works for me! If it's in the YAML, that note should show up if anyone copy/pastes it or if another doc uses it. If it was just in the surrounding text, it might not get noticed. Will that work for you @foxish ?

[campoy]

ping

[janetkuo]

Agree with @chenopis, lgtm

[janetkuo]

I saw a similar fix (closed) for this earlier, which proved that this is confusing enough for a fix

[foxish]

/lgtm