Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new page for feature gates that were removed #36876

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Sep 17, 2022

As the upstream code evolves, many feature gates (deprecated or GA'ed) are removed. That means they are no longer recognized by the Kubernetes components. This PR moves such feature gates into a dedicated page for reference so that we won't bother revisit them again for future releases.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 17, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 17, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 17, 2022
@netlify
Copy link

netlify bot commented Sep 17, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit 694d3c7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6326f3a638692b0008ed64f1
😎 Deploy Preview https://deploy-preview-36876--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

As the upstream code evolves, many feature gates (deprecated or GA'ed) are removed. That means they are no longer recognized by the Kubernetes components. This PR moves such feature gates into a dedicated page for reference so that we won't bother revisit them again for future releases.
@kbhawkey
Copy link
Contributor

👀

@sftim
Copy link
Contributor

sftim commented Sep 20, 2022

This seems reasonable. Should we discuss this change (issue? fortnightly Zoom call?) before we make it?

@reylejano
Copy link
Member

reylejano commented Sep 28, 2022

Preview of updated page:
https://deploy-preview-36876--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/
Preview of new page:
https://deploy-preview-36876--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates-removed/

I like the changes proposed in this pull request
Both alpha / beta and graduated / deprecated tables are very large.
Having a separate page for removed feature gates makes sense to me.

In a follow-up PR, I suggest updating the following from this page https://kubernetes.io/docs/contribute/new-content/new-features/#pr-ready-for-review

If your feature is GA'ed or deprecated, make sure to move it from that table to Feature gates for graduated or deprecated features table with Alpha and Beta history intact.

/label refactor

@k8s-ci-robot k8s-ci-robot added the refactor Indicates a PR with large refactoring changes e.g. removes files or moves content label Sep 28, 2022
@sftim
Copy link
Contributor

sftim commented Oct 2, 2022

This seems reasonable. Should we discuss this change (issue? fortnightly Zoom call?) before we make it?

A while has passed. I'm happy to approve this split.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2022
@natalisucks
Copy link
Contributor

Another happy approver has entered the thread 😸 thanks Qiming! And thanks to Rey and Tim for their own reviews and thoughts.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 79af5209e33a0c021dea95b4c3fca6882389a2c8

@k8s-ci-robot k8s-ci-robot merged commit bbf3510 into kubernetes:main Oct 2, 2022
@tengqm tengqm deleted the split-feature-gates branch October 2, 2022 23:04
@reylejano
Copy link
Member

In a follow-up PR, I suggest updating the following from this page https://kubernetes.io/docs/contribute/new-content/new-features/#pr-ready-for-review

If your feature is GA'ed or deprecated, make sure to move it from that table to Feature gates for graduated or deprecated features table with Alpha and Beta history intact.

Created follow-up PR #37153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants