Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Feature Gate CSRDuration under Feature Gates (removed) Page #36803

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Moved Feature Gate CSRDuration under Feature Gates (removed) Page #36803

merged 1 commit into from
Nov 14, 2022

Conversation

Shubham82
Copy link
Contributor

@Shubham82 Shubham82 commented Sep 14, 2022 •
edited
Loading

As the CSRDuration feature gate was graduated to GA in 1.24 and it has been removed in k8s v1.26, here is the PR which will remove it in the upcoming release k8s v1.26 k8s/k8s #112386. so as a reference to it, this PR removes the CSRDuration feature gate from Feature Gates docs.

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Sep 14, 2022
@netlify
Copy link

netlify bot commented Sep 14, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit dcf430b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/636cb6c73caae000082cec2a

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 14, 2022
@Shubham82
Copy link
Contributor Author

PTAL!

@Sea-n
Copy link
Member

Sea-n commented Sep 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@Shubham82
Copy link
Contributor Author

/assign @sftim

@tengqm
Copy link
Contributor

tengqm commented Sep 19, 2022

No. We don't have a page for "removed" feature gates yet. So far, please keep the docs as is. We are adding such a page (#36876). CSRDuration should be moved to the new page rather than being removed.

@tengqm
Copy link
Contributor

tengqm commented Sep 19, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2022
@Shubham82
Copy link
Contributor Author

No. We don't have a page for "removed" feature gates yet. So far, please keep the docs as is. We are adding such a page (#36876). CSRDuration should be moved to the new page rather than being removed.

sure, I will update it once it will merge and the removed feature gates page is available in the dev1.26 branch.

@sftim
Copy link
Contributor

sftim commented Oct 1, 2022

/lgtm cancel

This doesn't look right.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2022
@k8s-ci-robot k8s-ci-robot requested review from Sea-n and sftim October 1, 2022 20:55
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@Shubham82
Copy link
Contributor Author

As PR #37792 was merged now, so we have feature-gates-removed.md page available in the dev-1.26 branch, now i can move CSRduration feature gate under this page.

@Shubham82
Copy link
Contributor Author

Shubham82 commented Nov 10, 2022 •
edited
Loading

Removing the hold label from this PR.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@Shubham82 Shubham82 force-pushed the remove_CSRDuration_featuregate branch from e96771c to dcf430b Compare November 10, 2022 08:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@Shubham82 Shubham82 changed the title Removed Feature Gate: CSRDuration Moved Feature Gate CSRDuration under Feature Gates (removed) Page Nov 10, 2022
@tengqm
Copy link
Contributor

tengqm commented Nov 10, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@Shubham82
Copy link
Contributor Author

Hi @tengqm , @Sea-n
PTAL

@Shubham82
Copy link
Contributor Author

Hi, @tengqm could please time lgtm on this so that it will merge soon?

@tengqm
Copy link
Contributor

tengqm commented Nov 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb98583140830bcce5a174a6e3258efc383acf3f

@k8s-ci-robot k8s-ci-robot merged commit 224c6cb into kubernetes:dev-1.26 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@tengqm tengqm Awaiting requested review from tengqm

@Sea-n Sea-n Awaiting requested review from Sea-n

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

@Sea-n Sea-n

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
5 participants
@Shubham82 @Sea-n @tengqm @sftim @k8s-ci-robot