Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubelet flags that are no longer available. #33870

Merged
merged 17 commits into from
May 28, 2022
Merged

Remove kubelet flags that are no longer available. #33870

merged 17 commits into from
May 28, 2022

Conversation

tomkivlin
Copy link
Contributor

  • Removed refs deprecated with dockershim
  • Tweaked header levels
  • Added info about the changes in v1.24

Fixes #33640

tomkivlin added 2 commits May 21, 2022 12:59
@tomkivlin
Remove refs to dockershim
58aae61 
- Removed refs deprecated with dockershim
- Tweaked header levels
@tomkivlin
Added info about v1.24 changes
3b60dec
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2022
@k8s-ci-robot k8s-ci-robot requested a review from dcbw May 21, 2022 12:23
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 21, 2022
@k8s-ci-robot k8s-ci-robot requested a review from thockin May 21, 2022 12:23
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 21, 2022
@tomkivlin
Copy link
Contributor Author

#33862 (comment)

@kris-nova I've done a bare minimum update at this stage, but I wonder if a section in this page would be the right place for a "migrating from x to y" content, or whether it should go in the wider "migrating from dockershim" pages. What do you think?

@netlify
Copy link

netlify bot commented May 21, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c154e1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/628e3a14a4290f0009e32266
😎 Deploy Preview https://deploy-preview-33870--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tomkivlin tomkivlin changed the title Remove kubelet flags no longer available. Remove kubelet flags that are no longer available. May 23, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2022
@tomkivlin @tengqm
change to relative path
f453118 
Co-authored-by: Qiming Teng <[email protected]>
@tomkivlin
Copy link
Contributor Author

Direct link to Netlify version: https://deploy-preview-33870--kubernetes-io-main-staging.netlify.app/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/

@rolfedh rolfedh mentioned this pull request May 24, 2022
Closed
@rolfedh
Copy link
Contributor

rolfedh commented May 24, 2022

/assign @mikebrow

mikebrow
mikebrow reviewed May 24, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md Outdated Show resolved Hide resolved
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md Outdated Show resolved Hide resolved
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md Outdated Show resolved Hide resolved
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md Outdated Show resolved Hide resolved
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md Show resolved Hide resolved
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md Outdated Show resolved Hide resolved
content/en/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins.md Outdated Show resolved Hide resolved
@tomkivlin @rolfedh
Added comma
dbe825c 
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
tomkivlin and others added 2 commits May 24, 2022 17:29
@tomkivlin @rolfedh
Added hyphen
159ade8 
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
@tomkivlin @rolfedh
Added hyphen
a23668c 
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
tomkivlin and others added 2 commits May 24, 2022 17:30
@tomkivlin @rolfedh
Grammatical improvement
4f41ef3 
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
@tomkivlin @rolfedh
Added comma
16cdb0b 
Co-authored-by: Rolfe Dlugy-Hegwer <[email protected]>
rolfedh
rolfedh reviewed May 24, 2022
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some minor copy edits.

@tomkivlin
Copy link
Contributor Author

@mikebrow @rolfedh thanks for the comments/suggestions. I've made the changes, with the exception of just one I had a question about @mikebrow: #33870 (comment)

mikebrow
mikebrow approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with "the the" nit removed..

@tomkivlin
Copy link
Contributor Author

/assign @PI-Victor

@sftim
Copy link
Contributor

sftim commented May 28, 2022

LGTM from #33870 (review)
Preview LGTM
/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a7289426e7466ffd63a75763aeb8b1844b475e53

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikebrow, rolfedh, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit a7d02c4 into kubernetes:main May 28, 2022
@mtardy mtardy mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@mikebrow mikebrow mikebrow approved these changes

@rolfedh rolfedh rolfedh approved these changes

@dcbw dcbw Awaiting requested review from dcbw

@thockin thockin Awaiting requested review from thockin

Assignees

@PI-Victor PI-Victor

@mikebrow mikebrow

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network Plugins: --network-plugin flag is missing in 1.24.0, yet documented as available
7 participants
@tomkivlin @rolfedh @sftim @k8s-ci-robot @tengqm @mikebrow @PI-Victor