Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Plugins: --network-plugin flag is missing in 1.24.0, yet documented as available #33640

Closed
netikras opened this issue May 12, 2022 · 28 comments · Fixed by #33870
Closed
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@netikras
Copy link

image
ref: https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/

[root@CentOS-83-64-minimal ~]# kubelet --version
Kubernetes v1.20.4
[root@CentOS-83-64-minimal ~]# kubelet --help | grep network-plugin
      --network-plugin string                                    The name of the network plugin to be invoked for various events in kubelet/pod lifecycle. This docker-specific flag only works when container-runtime is set to docker.
      --network-plugin-mtu int32                                 The MTU to be passed to the network plugin, to override the default. Set to 0 to use the default 1460 MTU. This docker-specific flag only works when container-runtime is set to docker.
[root@CentOS-83-64-minimal ~]# 
root@netikras-hub:/etc/systemd/system/kubelet.service.d# kubelet --version
Kubernetes v1.24.0
root@netikras-hub:/etc/systemd/system/kubelet.service.d# kubelet --help | grep network-plugin
root@netikras-hub:/etc/systemd/system/kubelet.service.d# 
root@netikras-hub:/etc/systemd/system/kubelet.service.d# kubelet --network-plugin=cni 2>&1 | head -3
Error: failed to parse kubelet flag: unknown flag: --network-plugin
Usage:
  kubelet [flags]
root@netikras-hub:/etc/systemd/system/kubelet.service.d# 
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 12, 2022
@netikras netikras changed the title Network Plugins: --network-plugin flag is missing in 1.24.0, yet docummented as available Network Plugins: --network-plugin flag is missing in 1.24.0, yet documented as available May 12, 2022
@mk46
Copy link
Member

mk46 commented May 13, 2022

/sig node
/kind cleanup
If any flag found which was removed in kubernetes/kubernetes#106907, Kindly remove them too.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 13, 2022
@sftim
Copy link
Contributor

sftim commented May 15, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 15, 2022
@sftim
Copy link
Contributor

sftim commented May 15, 2022

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 15, 2022
@angelosnm
Copy link

For anyone facing this issue and Kubernetes is not starting, I removed the --network-plugin flag from /var/lib/kubelet/kubeadm-flags.env file and restarted kubelet service. (systemctl restart kubelet).

@sftim
Copy link
Contributor

sftim commented May 17, 2022

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label May 17, 2022
@KatsuoRyuu

This comment was marked as off-topic.

@mk46

This comment was marked as off-topic.

@KatsuoRyuu

This comment was marked as off-topic.

@mk46

This comment was marked as off-topic.

@angelosnm

This comment was marked as off-topic.

@mk46

This comment was marked as off-topic.

@angelosnm

This comment was marked as off-topic.

@sftim
Copy link
Contributor

sftim commented May 18, 2022

Folks, this is an accepted issue. We should update that page to remove mentions of the --network-plugin command line argument.

Pull requests are welcome - see https://kubernetes.io/docs/contribute/ for tips on how to contribute.

@colindawson

This comment was marked as off-topic.

@davidkarlsen

This comment was marked as off-topic.

@sftim
Copy link
Contributor

sftim commented May 20, 2022

I've marked some off-topic comments as hidden. They're not deleted (you can click Show comment to reveal them). Please, folks, do focus on the topic here: fixing the Kubernetes documentation about setting up cluster networking

@sftim
Copy link
Contributor

sftim commented May 20, 2022

If anyone has questions about how to propose a fix for https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/, you're very welcome to ask. You can reply here or, if you use the Kubernetes workspace for Slack, ask there in the #sig-docs channel.

@netikras
Copy link
Author

I've created a SO page to redirect all the "how to fix my cluster now" questions there: https://stackoverflow.com/questions/72316016/after-upgrading-to-kubelet-v1-24-clusted-does-not-start . Should I update the OP to reflect this link and state that this is not a request to fix the cluster's setup? @sftim

@sftim
Copy link
Contributor

sftim commented May 21, 2022

Duplicated by issue #33862

@sftim
Copy link
Contributor

sftim commented May 21, 2022

We should edit https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/network-plugins/ so that it is no longer incorrect, and then close this issue.

@sftim
Copy link
Contributor

sftim commented May 21, 2022

Anyone who wants to edit that page is welcome to.

@tomkivlin
Copy link
Contributor

/assign

@rolfedh
Copy link
Contributor

rolfedh commented May 24, 2022

@mikebrow is reviewing @tomkivlin's PR #33870

@duanhaowei
Copy link

remove " --network-plugin"flag work fine.

@mperlik
Copy link

mperlik commented Jun 19, 2022

For anyone facing this issue and Kubernetes is not starting, I removed the --network-plugin flag from /var/lib/kubelet/kubeadm-flags.env file and restarted kubelet service. (systemctl restart kubelet).

This resulted in my case just in another error:

Jun 19 09:15:47 k8s-1m kubelet[1752935]: W0619 09:15:47.044045 1752935 clientconn.go:1331] [core] grpc: addrConn.createTransport failed to connect to {  <nil> 0 <nil>}. Err: connection error: desc = "transport: Error while dialing dial unix: missing address". Reconnecting...
Jun 19 09:15:47 k8s-1m kubelet[1752935]: Error: failed to run Kubelet: unable to determine runtime API version: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial unix: missing address"

@BastienVigneron

This comment was marked as off-topic.

@Zappelphilipp

This comment was marked as off-topic.

@kubernetes kubernetes locked as resolved and limited conversation to collaborators Jun 27, 2022
@sftim
Copy link
Contributor

sftim commented Jun 27, 2022

As this bug is resolved, I'm going to lock it to ensure that the record remains on-topic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet