Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubeadm config API #33839

Merged
merged 1 commit into from
May 25, 2022
Merged

Update kubeadm config API #33839

merged 1 commit into from
May 25, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented May 19, 2022

closes: #33835

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels May 19, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 19, 2022
@neolit123
Copy link
Member

Thanks
/lgtm
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label May 20, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e2ec6e65169e81bc207daa0f157dece5a4669b6a

@netlify
Copy link

netlify bot commented May 21, 2022

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 10ae838
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6286c712ddf56b0008ae7425
😎 Deploy Preview https://deploy-preview-33839--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reylejano
Copy link
Member

Preview of updated pages:

/lgtm

@reylejano
Copy link
Member

There is a second lgtm from neolit123
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 86993dc into kubernetes:main May 25, 2022
@tengqm tengqm deleted the update-kubeadm-configapi branch May 25, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@neolit123 neolit123

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm API reference docs still mention "master" taint
4 participants
@tengqm @neolit123 @k8s-ci-robot @reylejano