Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm API reference docs still mention "master" taint #33835

Closed
neolit123 opened this issue May 19, 2022 · 3 comments · Fixed by #33839
Closed

kubeadm API reference docs still mention "master" taint #33835

neolit123 opened this issue May 19, 2022 · 3 comments · Fixed by #33839
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@neolit123
Copy link
Member

neolit123 commented May 19, 2022

This is a Bug Report

Problem:

while cleaning up mentions of the legacy "master" taint in kubeadm docs:
#33834

saw the following:

~/go/src/k8s.io/website/content/en/docs$ grep "node-role.kubernetes.io/master" * -rnI
reference/config-api/kubeadm-config.v1beta2.md:1280:<code>'node-role.kubernetes.io/master=&quot;&quot;'</code>. If you don't want to taint your control-plane node,
reference/config-api/kubeadm-config.v1beta3.md:1267:<code>taints: [&quot;node-role.kubernetes.io/master:&quot;&quot;]</code>.

it seems the generated reference API docs for kubeadm still include the "master" taint.

Proposed Solution:

cleanup mentions of the old taint from kubeadm's API reference docs at k8s.io.

perhaps these need to be synced with:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta2/doc.go
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta3/doc.go

for dev-1.25 and main at k/website

we removed the old taint from there before 1.24 was released.

Page to Update:

https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta2/
https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta3/

@neolit123 neolit123 added the kind/bug Categorizes issue or PR as related to a bug. label May 19, 2022
@k8s-ci-robot
Copy link
Contributor

@neolit123: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 19, 2022
@neolit123
Copy link
Member Author

/sig cluster-lifecycle
/priority important-soon
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 19, 2022
@neolit123
Copy link
Member Author

cc @tengqm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants