-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pod eviction concept topic #27739
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit c184f20 https://deploy-preview-27739--kubernetes-io-master-staging.netlify.app |
I agree that https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/ doesn't really explain a task. We could actually redirect it to the new page if we don't replace it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early feedback that I hope is useful
I ported over content from the Out of Resource Handling topic (and made lots of edits to it). We can remove that topic entirely. Same for "Eviction Policy" - that content is now in Eviction.md. |
@sftim I've reached out to |
/cc @dashpole @bobbypage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented some of @dashpole's edits and added followups to others.
108a1fb
to
2e1ac21
Compare
cc4d451
to
c184f20
Compare
LGTM label has been added. Git tree hash: 144a5aeeb93c9a85550516b0cea2307ad524f666
|
👀 |
@sftim what else do I need for approval on this one? |
If someone who's not me LGTMs this, I can approve it. |
@alculquicondor sorry, I pushed to implement your final comment and it removed your lgtm. Would you mind adding it again? Thanks! |
/lgtm still applies :) |
Let's do this |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
I’ve been a member for a fair bit. Reviewed, worked on, or been involved in tracking 50+ PRs. Some highlights: * kubernetes#26848 * kubernetes#27716 * kubernetes#27739 * kubernetes#28870 * kubernetes#28740 * kubernetes#28617 Search for PRs involving me: https://github.com/kubernetes/website/pulls?page=2&q=is%3Apr+involves%3Ashannonxtreme
Description
Work for #14507
Created a new draft concept topic for Pod Eviction. Merged content from out-of-resource.md and eviction-policy.md.
Questions/comments
Closed issues
[Line 37] - the control plane, the scheduler, or "the control plane or kube-controller manager"?[Line 88-91] - What is the best way to describenodefs
andimagefs
? Related comment thread.[Line 96-100] - Has the kubelet deprecated garbage collection for eviction in DiskPressure conditions?[Line 245-251] - should we reword to make it clear that only the pods' cgroup is checked for memory eviction? Related commentVerify that the Known Issues list and any areas marked for "future deprecation" are still valid.https://kubernetes.io/docs/tasks/administer-cluster/out-of-resource/ has many conceptual sections which I suggest we move to this topic. That task topic doesn't actually have any "tasks". We should consider adding instructions in that topic for actually configuring the parameters, and move the conceptual info to theEviction Parameters
section in this concept topic.Where does this topic belong? Scheduling and Eviction or Cluster Administration? Related discussion thread[Line 199-216] - does "garbage collect" replace "delete" in all four points?/sig docs
/language en
/do-not-merge work-in-progress
/assign @sftim