Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoS class isn't used for out-of-resource handling rankings #27753

Closed
shannonxtreme opened this issue Apr 27, 2021 · 4 comments · Fixed by #27754
Closed

QoS class isn't used for out-of-resource handling rankings #27753

shannonxtreme opened this issue Apr 27, 2021 · 4 comments · Fixed by #27754
Assignees
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@shannonxtreme
Copy link
Contributor

Page: https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#interactions-of-pod-priority-and-qos

The second paragraph needs clarity. The QoS class isn't actually used to calculate the pod eviction order, but can be used to estimate the order.

Suggested content

The kubelet uses Priority to order pods for out-of-resource eviction. You can use the QoS class to estimate the order in which pods are most likely to get evicted. The kubelet ranks pods for eviction based on the following factors:

  1. Whether or not the pod resource usage exceeds the defined requests
  2. The pod Priority
  3. The amount of the pod's resource consumption relative to the defined requests

For more information, see [Evicting end-user pods].

Note: this will likely link to #27739 instead of the existing Out of Resource Handling topic.

/sig docs
/language en
/assign

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 27, 2021
@k8s-ci-robot
Copy link
Contributor

@shannonxtreme: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Apr 27, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 27, 2021
@shannonxtreme
Copy link
Contributor Author

/triage accepted

eh, worth a shot

@k8s-ci-robot
Copy link
Contributor

@shannonxtreme: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

In response to this:

/triage accepted

eh, worth a shot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants