Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ja: Make docs/setup/production-environment/turnkey/aws.md follow v1.18 of the original text #26637

Merged
merged 2 commits into from
Feb 27, 2021
Merged

ja: Make docs/setup/production-environment/turnkey/aws.md follow v1.18 of the original text #26637

merged 2 commits into from
Feb 27, 2021

Conversation

tettsu
Copy link
Contributor

@tettsu tettsu commented Feb 20, 2021

Close #26517

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @tettsu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 20, 2021
@kakts
Copy link
Member

kakts commented Feb 25, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad7f28a79f4bf87ee3eebaa7411025d53fd38149

@tettsu tettsu requested a review from inductor February 26, 2021 14:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2021
@inductor
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 858e793969a340d4978b9d57e7afaf72ebd2d698

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit a46c896 into kubernetes:dev-1.18-ja.2 Feb 27, 2021
@inductor inductor mentioned this pull request Mar 3, 2021
Merged
@tettsu tettsu deleted the fix/setup-aws branch March 13, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bells17 bells17 Awaiting requested review from bells17

@nasa9084 nasa9084 Awaiting requested review from nasa9084

@inductor inductor Awaiting requested review from inductor

Assignees

@kakts kakts

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tettsu @k8s-ci-robot @kakts @inductor