Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] removed install-minikube.md #26495

Merged
merged 3 commits into from
Feb 16, 2021
+5 −271
Merged

[ja] removed install-minikube.md #26495

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e7cf5
delete /ja/docs/tasks/tools/install-kubectl/
mox692 Feb 14, 2021
485d01d
fix: _redirects
mox692 Feb 14, 2021
b3d69ac
Update content/ja/docs/setup/learning-environment/minikube.md
inductor Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/ja/docs/setup/learning-environment/minikube.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ MinikubeのサポートするKubernetesの機能:

## インストール

[Minikubeのインストール](/ja/docs/tasks/tools/install-minikube/)を参照してください。
ツールのインストールについて知りたい場合は、公式の[Get Started!](https://minikube.sigs.k8s.io/docs/start/)のガイドにしたがってください。
inductor marked this conversation as resolved.
Show resolved Hide resolved

## クイックスタート

Expand Down
2 changes: 1 addition & 1 deletion content/ja/docs/tasks/tools/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Kubernetesのコマンドラインツール`kubectl`を使用すると、Kuberne

[Minikube](https://minikube.sigs.k8s.io/)は、Kubernetesをローカルで実行するツールです。MinikubeはシングルノードのKubernetesクラスターをパーソナルコンピューター上(Windows、macOS、Linux PCを含む)で実行することで、Kubernetesを試したり、日常的な開発作業のために利用できます。

ツールのインストールについて知りたい場合は、公式の[Get Started!](https://minikube.sigs.k8s.io/docs/start/)のガイドに従うか、[Minikubeのインストール](/ja/docs/tasks/tools/install-minikube/)を読んでください。
ツールのインストールについて知りたい場合は、公式の[Get Started!](https://minikube.sigs.k8s.io/docs/start/)のガイドに従ってください。

Minikubeが起動したら、[サンプルアプリケーションの実行](/ja/docs/tutorials/hello-minikube/)を試すことができます。

Expand Down
2 changes: 1 addition & 1 deletion content/ja/docs/tasks/tools/install-kubectl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ compinit

## {{% heading "whatsnext" %}}

* [Minikubeをインストールする](/ja/docs/tasks/tools/install-minikube/)
* [Minikubeをインストールする](https://minikube.sigs.k8s.io/docs/start/)
* クラスターの作成に関する詳細を[スタートガイド](/ja/docs/setup/)で確認する
* [アプリケーションを起動して公開する方法を学ぶ](/ja/docs/tasks/access-application-cluster/service-access-application-cluster/)
* あなたが作成していないクラスターにアクセスする必要がある場合は、[クラスターアクセスドキュメントの共有](/ja/docs/tasks/access-application-cluster/configure-access-multiple-clusters/)を参照してください
Expand Down
267 changes: 0 additions & 267 deletions content/ja/docs/tasks/tools/install-minikube.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion content/ja/docs/tutorials/hello-minikube.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ card:
このチュートリアルでは、[Minikube](/ja/docs/setup/learning-environment/minikube)とKatacodaを使用して、Kubernetes上でサンプルアプリケーションを動かす方法を紹介します。Katacodaはブラウザで無償のKubernetes環境を提供します。

{{< note >}}
[Minikubeをローカルにインストール](/ja/docs/tasks/tools/install-minikube/)している場合もこのチュートリアルを進めることが可能です。
[Minikubeをローカルにインストール](https://minikube.sigs.k8s.io/docs/start/)している場合もこのチュートリアルを進めることが可能です。
{{< /note >}}


Expand Down
1 change: 1 addition & 0 deletions static/_redirects
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@
/docs/tasks/run-application/podpreset/ /docs/tasks/inject-data-application/podpreset/ 301
/docs/tasks/run-application/update-api-object-kubectl-patch/ /docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch/ 301
/docs/tasks/stateful-sets/deleting-pods/ /docs/tasks/run-application/force-delete-stateful-set-pod/ 301
/ja/docs/tasks/tools/install-minikube/ https://minikube.sigs.k8s.io/docs/start/ 302
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mox692 .
I checked that /docs/tasks/tools/install-minikube/ redirects to the minikube docs.
Does /ja/docs/tasks/tools/install-minikube/ redirect?

Page preview:
https://deploy-preview-26495--kubernetes-io-master-staging.netlify.app/ja/docs/tutorials/hello-minikube/

Otherwise, the other links look correct.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check redirect is working, I tried to build website locally, but not succeed.

$ make container-image
docker build . \
		--network=host \
		--tag kubernetes-hugo:v0.74.3-1ead0bb5edad \
		--build-arg HUGO_VERSION=0.74.3
Sending build context to Docker daemon  3.584kB
Step 1/8 : FROM alpine:latest
 ---> e50c909a8df2
Step 2/8 : LABEL maintainer="Luc Perkins <[email protected]>"
 ---> Using cache
 ---> 54c07b406044
Step 3/8 : RUN apk add --no-cache     curl     git     openssh-client     rsync     build-base     libc6-compat     npm &&     npm install -D autoprefixer postcss-cli
 ---> Using cache
 ---> 9f5c37054fec
Step 4/8 : ARG HUGO_VERSION
 ---> Using cache
 ---> d0ef7dda007e
Step 5/8 : RUN mkdir -p /usr/local/src &&     cd /usr/local/src &&     curl -L https://github.com/gohugoio/hugo/releases/download/v${HUGO_VERSION}/hugo_extended_${HUGO_VERSION}_Linux-64bit.tar.gz | tar -xz &&     mv hugo /usr/local/bin/hugo &&     addgroup -Sg 1000 hugo &&     adduser -Sg hugo -u 1000 -h /src hugo
 ---> Running in d6ea0acf9102
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: github.com
tar: invalid magic
tar: short read
The command '/bin/sh -c mkdir -p /usr/local/src &&     cd /usr/local/src &&     curl -L https://github.com/gohugoio/hugo/releases/download/v${HUGO_VERSION}/hugo_extended_${HUGO_VERSION}_Linux-64bit.tar.gz | tar -xz &&     mv hugo /usr/local/bin/hugo &&     addgroup -Sg 1000 hugo &&     adduser -Sg hugo -u 1000 -h /src hugo' returned a non-zero code: 1

I haven't investigated this error yet. I'll check this later.
If hurry, Could anyone who can build website locally check the redirect instead?

Thank you:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error says tar ball of hugo downloading fails so maybe you can retry?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mox692.
Is the plan to merge these changes to dev-1.18-ja.2 and then merge this branch (along with other changes) to release-1.18 or possibly master? If so, I think it is okay to merge these changes in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the ja localization team approves, feel free to remove the hold.
/approve
/hold

/docs/tasks/troubleshoot/debug-init-containers/ /docs/tasks/debug-application-cluster/debug-init-containers/ 301
/docs/tasks/web-ui-dashboard/ /docs/tasks/access-application-cluster/web-ui-dashboard/ 301

Expand Down