[ja] removed install-minikube.md #26495

mox692 · 2021-02-13T12:29:00Z

from #26492
I changed the text and link-destination refering to this this part.

If there is some reason that link-destination should NOT be like here, but be here, sorry for noisy.

netlify · 2021-02-13T12:39:28Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 43d2c8b

https://deploy-preview-26495--kubernetes-io-master-staging.netlify.app

mox692 · 2021-02-13T13:33:43Z

/check-cla

bells17 · 2021-02-14T07:30:09Z

Hi @mox692

I checked this page, and the original content was already deleted.
So I think need to delete this page.
#24416

Could you change the PR to delete this page?
And please change the base branch to dev-1.18-ja.2 for the following reasons:

Kubernetesのドキュメントを翻訳する

bells17 · 2021-02-14T07:37:39Z

#26504

mox692 · 2021-02-14T09:47:01Z

Hi @bells17 ,
I removed install-minikube.md and change referenced part in 61e7cf5,
so please check it🙏

And I want to rerun the netlify with the latest commit 61e7cf5, is there any way to do this?

bells17

Thank you.
I commented on this PR, so please check my comment.

bells17 · 2021-02-14T10:26:49Z

static/_redirects

@@ -281,6 +281,7 @@
 /docs/tasks/run-application/podpreset/     /docs/tasks/inject-data-application/podpreset/ 301
 /docs/tasks/run-application/update-api-object-kubectl-patch/    /docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch/ 301
 /docs/tasks/stateful-sets/deleting-pods/     /docs/tasks/run-application/force-delete-stateful-set-pod/ 301
+ja/docs/tasks/tools/install-minikube/     https://minikube.sigs.k8s.io/docs/start/ 302


Suggested change

ja/docs/tasks/tools/install-minikube/ https://minikube.sigs.k8s.io/docs/start/ 302

/ja/docs/tasks/tools/install-minikube/ https://minikube.sigs.k8s.io/docs/start/ 302

ref:

website/static/_redirects

Line 306 in 61e7cf5

/ja/docs/tutorials/kubernetes-basics/scale-intro/ /ja/docs/tutorials/kubernetes-basics/scale/scale-intro/ 301

website/static/_redirects

Line 310 in 61e7cf5

/ja/docs/tutorials/kubernetes-basics/update-intro/ /ja/docs/tutorials/kubernetes-basics/update/update-intro/ 301

website/static/_redirects

Line 478 in 61e7cf5

/ja/docs/setup/independent/install-kubeadm/ /ja/docs/setup/production-environment/tools/kubeadm/install-kubeadm/ 301

fix: 485d01d

bells17 · 2021-02-14T10:35:44Z

And I want to rerun the netlify with the latest commit 61e7cf5, is there any way to do this?

Um...You need to change the base branch to master if you want to deploy to netlify.
You can check the updated website on localhost.

k8s-ci-robot · 2021-02-14T16:42:21Z

LGTM label has been added.

Git tree hash: 5a7f6f065d479032df2277cfa87b53d1bb649a10

content/ja/docs/setup/learning-environment/minikube.md

nasa9084 · 2021-02-15T08:42:54Z

/assign @inductor

inductor · 2021-02-15T08:48:36Z

@mox692 @nasa9084
Since static/_redirects is changed, I do not have permission to accept this.
/assign @kbhawkey

inductor · 2021-02-15T08:48:47Z

/unassign

inductor · 2021-02-15T12:03:31Z

/lgtm

k8s-ci-robot · 2021-02-15T12:03:41Z

LGTM label has been added.

Git tree hash: 8f21c9b73b2e3f1fa8a212b38322c54b34ff9a00

kbhawkey · 2021-02-15T16:14:59Z

static/_redirects

@@ -281,6 +281,7 @@
 /docs/tasks/run-application/podpreset/     /docs/tasks/inject-data-application/podpreset/ 301
 /docs/tasks/run-application/update-api-object-kubectl-patch/    /docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch/ 301
 /docs/tasks/stateful-sets/deleting-pods/     /docs/tasks/run-application/force-delete-stateful-set-pod/ 301
+/ja/docs/tasks/tools/install-minikube/     https://minikube.sigs.k8s.io/docs/start/ 302


Hi @mox692 .
I checked that /docs/tasks/tools/install-minikube/ redirects to the minikube docs.
Does /ja/docs/tasks/tools/install-minikube/ redirect?

Page preview:
https://deploy-preview-26495--kubernetes-io-master-staging.netlify.app/ja/docs/tutorials/hello-minikube/

Otherwise, the other links look correct.

Thanks!

To check redirect is working, I tried to build website locally, but not succeed.

$ make container-image docker build . \ --network=host \ --tag kubernetes-hugo:v0.74.3-1ead0bb5edad \ --build-arg HUGO_VERSION=0.74.3 Sending build context to Docker daemon 3.584kB Step 1/8 : FROM alpine:latest ---> e50c909a8df2 Step 2/8 : LABEL maintainer="Luc Perkins <[email protected]>" ---> Using cache ---> 54c07b406044 Step 3/8 : RUN apk add --no-cache curl git openssh-client rsync build-base libc6-compat npm && npm install -D autoprefixer postcss-cli ---> Using cache ---> 9f5c37054fec Step 4/8 : ARG HUGO_VERSION ---> Using cache ---> d0ef7dda007e Step 5/8 : RUN mkdir -p /usr/local/src && cd /usr/local/src && curl -L https://github.com/gohugoio/hugo/releases/download/v${HUGO_VERSION}/hugo_extended_${HUGO_VERSION}_Linux-64bit.tar.gz | tar -xz && mv hugo /usr/local/bin/hugo && addgroup -Sg 1000 hugo && adduser -Sg hugo -u 1000 -h /src hugo ---> Running in d6ea0acf9102 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (6) Could not resolve host: github.com tar: invalid magic tar: short read The command '/bin/sh -c mkdir -p /usr/local/src && cd /usr/local/src && curl -L https://github.com/gohugoio/hugo/releases/download/v${HUGO_VERSION}/hugo_extended_${HUGO_VERSION}_Linux-64bit.tar.gz | tar -xz && mv hugo /usr/local/bin/hugo && addgroup -Sg 1000 hugo && adduser -Sg hugo -u 1000 -h /src hugo' returned a non-zero code: 1

I haven't investigated this error yet. I'll check this later.
If hurry, Could anyone who can build website locally check the redirect instead?

Thank you:)

The error says tar ball of hugo downloading fails so maybe you can retry?

Hi @mox692.
Is the plan to merge these changes to dev-1.18-ja.2 and then merge this branch (along with other changes) to release-1.18 or possibly master? If so, I think it is okay to merge these changes in.

Assuming the ja localization team approves, feel free to remove the hold.
/approve
/hold

k8s-ci-robot · 2021-02-16T20:00:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kbhawkey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kbhawkey · 2021-02-16T20:00:56Z

/remove-area blog

inductor · 2021-02-16T23:36:07Z

/unhold

@kbhawkey Thank you for your work!

mox692 · 2021-02-18T17:38:08Z

sorry for late reply, and thank you for all help :)

k8s-ci-robot requested review from kakts and makocchi-git February 13, 2021 12:29

k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2021

mox692 mentioned this pull request Feb 13, 2021

[ja page fix]ambiguous link destination in /content/ja/docs/tasks/tools/install-minikube.md #26492

Closed

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 13, 2021

mox692 changed the base branch from master to dev-1.18-ja.2 February 14, 2021 08:19

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2021

delete /ja/docs/tasks/tools/install-kubectl/

61e7cf5

mox692 force-pushed the fix/link branch from 43d2c8b to 61e7cf5 Compare February 14, 2021 09:03

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2021

mox692 changed the title ~~fix link destination in ja document.~~ [ja] removed install-minikube.md Feb 14, 2021

bells17 reviewed Feb 14, 2021

View reviewed changes

fix: _redirects

485d01d

mox692 force-pushed the fix/link branch from 61e7cf5 to 43d2c8b Compare February 14, 2021 14:07

k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language labels Feb 14, 2021

k8s-ci-robot requested review from inductor and nasa9084 February 14, 2021 16:42

k8s-ci-robot assigned bells17 Feb 14, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2021

inductor requested changes Feb 15, 2021

View reviewed changes

content/ja/docs/setup/learning-environment/minikube.md Outdated Show resolved Hide resolved

k8s-ci-robot assigned inductor Feb 15, 2021

k8s-ci-robot assigned kbhawkey Feb 15, 2021

k8s-ci-robot unassigned inductor Feb 15, 2021

Update content/ja/docs/setup/learning-environment/minikube.md

b3d69ac

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2021

inductor self-requested a review February 15, 2021 12:03

k8s-ci-robot assigned inductor Feb 15, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2021

kbhawkey reviewed Feb 15, 2021

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021

k8s-ci-robot removed the area/blog Issues or PRs related to the Kubernetes Blog subproject label Feb 16, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2021

k8s-ci-robot merged commit f40f464 into kubernetes:dev-1.18-ja.2 Feb 16, 2021

inductor mentioned this pull request Mar 3, 2021

Second Japanese l10n work for release-1.18 #26817

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ja] removed install-minikube.md #26495

[ja] removed install-minikube.md #26495

mox692 commented Feb 13, 2021 •

edited

Loading

netlify bot commented Feb 13, 2021

mox692 commented Feb 13, 2021

bells17 commented Feb 14, 2021 •

edited

Loading

bells17 commented Feb 14, 2021 •

edited

Loading

mox692 commented Feb 14, 2021 •

edited

Loading

bells17 left a comment

bells17 Feb 14, 2021

bells17 Feb 14, 2021 •

edited

Loading

mox692 Feb 14, 2021

bells17 commented Feb 14, 2021

k8s-ci-robot commented Feb 14, 2021

nasa9084 commented Feb 15, 2021

inductor commented Feb 15, 2021 •

edited

Loading

inductor commented Feb 15, 2021

inductor commented Feb 15, 2021

k8s-ci-robot commented Feb 15, 2021

kbhawkey Feb 15, 2021

mox692 Feb 16, 2021

inductor Feb 16, 2021

kbhawkey Feb 16, 2021

kbhawkey Feb 16, 2021

k8s-ci-robot commented Feb 16, 2021

kbhawkey commented Feb 16, 2021

inductor commented Feb 16, 2021

mox692 commented Feb 18, 2021 •

edited

Loading

	ja/docs/tasks/tools/install-minikube/ https://minikube.sigs.k8s.io/docs/start/ 302
	/ja/docs/tasks/tools/install-minikube/ https://minikube.sigs.k8s.io/docs/start/ 302

[ja] removed install-minikube.md #26495

[ja] removed install-minikube.md #26495

Conversation

mox692 commented Feb 13, 2021 • edited Loading

netlify bot commented Feb 13, 2021

mox692 commented Feb 13, 2021

bells17 commented Feb 14, 2021 • edited Loading

bells17 commented Feb 14, 2021 • edited Loading

mox692 commented Feb 14, 2021 • edited Loading

bells17 left a comment

Choose a reason for hiding this comment

bells17 Feb 14, 2021

Choose a reason for hiding this comment

bells17 Feb 14, 2021 • edited Loading

Choose a reason for hiding this comment

mox692 Feb 14, 2021

Choose a reason for hiding this comment

bells17 commented Feb 14, 2021

k8s-ci-robot commented Feb 14, 2021

nasa9084 commented Feb 15, 2021

inductor commented Feb 15, 2021 • edited Loading

inductor commented Feb 15, 2021

inductor commented Feb 15, 2021

k8s-ci-robot commented Feb 15, 2021

kbhawkey Feb 15, 2021

Choose a reason for hiding this comment

mox692 Feb 16, 2021

Choose a reason for hiding this comment

inductor Feb 16, 2021

Choose a reason for hiding this comment

kbhawkey Feb 16, 2021

Choose a reason for hiding this comment

kbhawkey Feb 16, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 16, 2021

kbhawkey commented Feb 16, 2021

inductor commented Feb 16, 2021

mox692 commented Feb 18, 2021 • edited Loading

mox692 commented Feb 13, 2021 •

edited

Loading

bells17 commented Feb 14, 2021 •

edited

Loading

bells17 commented Feb 14, 2021 •

edited

Loading

mox692 commented Feb 14, 2021 •

edited

Loading

bells17 Feb 14, 2021 •

edited

Loading

inductor commented Feb 15, 2021 •

edited

Loading

mox692 commented Feb 18, 2021 •

edited

Loading