Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm podpreset #25238

Merged
merged 1 commit into from
Nov 26, 2020
Merged

rm podpreset #25238

merged 1 commit into from
Nov 26, 2020

Conversation

jlsong01
Copy link
Contributor

to address issue: #24038

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 1b7708b

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fbe7ad7c88717000704578c

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 25, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2020
@jlsong01 jlsong01 changed the title rm podpresent rm podpreset Nov 25, 2020
@annajung
Copy link
Contributor

Thank you @jlsong01

/milestone 1.20
/assign @sftim @tengqm

/lgtm

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 25, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd22c307b866252f9c2d0b90a610b0c9cb4a58a9

@tengqm
Copy link
Contributor

tengqm commented Nov 26, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit b138a70 into kubernetes:dev-1.20 Nov 26, 2020
@sftim sftim mentioned this pull request Nov 26, 2020
Closed
@s-kawamura-w664 s-kawamura-w664 mentioned this pull request Mar 6, 2023
Merged
@s-kawamura-w664 s-kawamura-w664 mentioned this pull request Mar 14, 2023
Merged
@earth429 earth429 mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessfraz jessfraz Awaiting requested review from jessfraz

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@tengqm tengqm

@sftim sftim

@annajung annajung

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@jlsong01 @k8sio-netlify-preview-bot @annajung @k8s-ci-robot @tengqm @sftim