Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of document link in some ko documents #22379

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Jul 6, 2020

Closes #22378

This issue related with #22372 and it has been merged recently.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/ko Issues or PRs related to Korean language labels Jul 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from ianychoi and ysyukr July 6, 2020 04:41
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 6, 2020
@netlify
Copy link

netlify bot commented Jul 6, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit 62a5951

https://deploy-preview-22379--k8s-dev-ko.netlify.app

@gochist
Copy link
Member

gochist commented Jul 6, 2020

@pjhwa 감사합니다! master 브랜치의 변경을 미리 적용해주셨는데, 되도록이면 팀 마일스톤 브랜치(dev-1.18-ko.7) 내의 영문 문서를 기준으로 작업하고, 팀 마일스톤 브랜치가 분기된 이후 master 브랜치에서 일어난 업스트림의 변경은 다음 마일스톤 브랜치에서 현행화하는 것이 좋을 것 같습니다.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@gochist
Copy link
Member

gochist commented Jul 6, 2020

/assign @seokho-son
/unassign

@k8s-ci-robot k8s-ci-robot assigned seokho-son and unassigned gochist Jul 6, 2020
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 6, 2020

@pjhwa 감사합니다! master 브랜치의 변경을 미리 적용해주셨는데, 되도록이면 팀 마일스톤 브랜치(dev-1.18-ko.7) 내의 영문 문서를 기준으로 작업하고, 팀 마일스톤 브랜치가 분기된 이후 master 브랜치에서 일어난 업스트림의 변경은 다음 마일스톤 브랜치에서 현행화하는 것이 좋을 것 같습니다.

/lgtm

네, 제가 좀 성급했나봅니다. 향후에는 가이드 주신대로 작업하도록 하겠습니다.

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 81f244e into kubernetes:dev-1.18-ko.7 Jul 7, 2020
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <[email protected]>
Co-authored-by: woopyoung <[email protected]>
Co-authored-by: coolguyhong <[email protected]>
Co-authored-by: PyungHo Yoon <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
Co-authored-by: jmyung <[email protected]>
Co-authored-by: Ian Y. Choi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants