Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow v1.17 ja version: concepts/overview/kubernetes-api.md #22250

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Follow v1.17 ja version: concepts/overview/kubernetes-api.md #22250

merged 1 commit into from
Jul 6, 2020

Conversation

translucens
Copy link
Contributor

Close #21840

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from nasa9084 and oke-py July 1, 2020 15:23
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 1, 2020
@translucens
Copy link
Contributor Author

/assign @inductor

inductor
inductor reviewed Jul 1, 2020
View reviewed changes
Copy link
Member

@inductor inductor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@nasa9084
Copy link
Member

nasa9084 commented Jul 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit e70fc60 into kubernetes:dev-1.17-ja.3 Jul 6, 2020
@translucens translucens deleted the issue-21840 branch July 6, 2020 07:41
@inductor inductor mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inductor inductor inductor left review comments

@nasa9084 nasa9084 Awaiting requested review from nasa9084

@oke-py oke-py Awaiting requested review from oke-py

Assignees

@nasa9084 nasa9084

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@translucens @k8s-ci-robot @nasa9084 @inductor