Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s.io/docs/tutorials/hello-minikube #18673

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Update k8s.io/docs/tutorials/hello-minikube #18673

merged 2 commits into from
Jan 16, 2020

Conversation

Kartik494
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 14, 2020
@php-coder
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2020
php-coder
php-coder reviewed Jan 14, 2020
View reviewed changes
content/en/docs/tutorials/hello-minikube.md Outdated
@@ -236,22 +235,22 @@ Minikube has a set of built-in addons that can be enabled, disabled and opened i
pod/storage-provisioner 1/1 Running 0 34m

NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
service/heapster ClusterIP 10.96.241.45 <none> 80/TCP 26s
service/metrics-server ClusterIP 10.96.241.45 <none> 80/TCP 26s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, we could improve alignment here? Or it isn't an issue in a rendered form?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@php-code the deploy preview shows how this will look (see the deploy/netlify section of the checks list for a link to the preview).

Seems like your concern is valid.
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2020
@php-coder php-coder mentioned this pull request Jan 14, 2020
Merged
@php-coder
Copy link
Contributor

@Kartik494 Only one really small improvement is needed. Could you address it when you have time? Thanks!

@Kartik494
Copy link
Contributor Author

@php-coder @sftim i have addressed the changes.Please check
Thanks

php-coder
php-coder approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2020
@sftim
Copy link
Contributor

sftim commented Jan 16, 2020

/approve
Thanks @Kartik494 !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9b9910c into kubernetes:master Jan 16, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@Kartik494 @wawa0210
Update k8s.io/docs/tutorials/hello-minikube (kubernetes#18673)
8e47d2a 
* Update k8s.io/docs/tutorials/hello-minikube

* Update hello-minikube.md
This was referenced Mar 2, 2020
Closed
Closed
@Kartik494 Kartik494 mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder approved these changes

@sftim sftim Awaiting requested review from sftim

@zparnold zparnold Awaiting requested review from zparnold

Assignees

@php-coder php-coder

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kartik494 @php-coder @sftim @k8s-ci-robot