Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for k8s.io/docs/tutorials/hello-minikube/ #18420

Closed
jmichalik opened this issue Jan 2, 2020 · 7 comments
Closed

Improvement for k8s.io/docs/tutorials/hello-minikube/ #18420

jmichalik opened this issue Jan 2, 2020 · 7 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@jmichalik
Copy link

jmichalik commented Jan 2, 2020

Heapster is not available in the add on list. Maybe it needs to be added to the docker image.

@sftim
Copy link
Contributor

sftim commented Jan 2, 2020

@jmichalik would you be willing to capture some diagnostic information about the version of minikube that you're using?
Was this using the terminal-version on the website, or Minikube locally? If locally, what version of minikube and how is it set up?

@BenHall
Copy link
Contributor

BenHall commented Jan 2, 2020

Thanks. It looks like Heapster is no longer a Minikube addon and has been replaced by metrics-server - https://minikube.sigs.k8s.io/docs/tasks/addons/

When Katacoda moved to 1.17 it's highlighted the out-dated docs.

I will raise a PR to update

@sftim
Copy link
Contributor

sftim commented Jan 2, 2020

/kind cleanup
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 2, 2020
@jmichalik
Copy link
Author

@sftim I am using the terminal-version on the website.

@php-coder
Copy link
Contributor

In #18611 I applied Russian-related changes from #18422 Thank you, @BenHall

@php-coder
Copy link
Contributor

The issue was fixed by #18673
/close

@k8s-ci-robot
Copy link
Contributor

@php-coder: Closing this issue.

In response to this:

The issue was fixed by #18673
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants