Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to replicated stateful application #17732

Closed
wants to merge 1 commit into from
Closed

Fix link to replicated stateful application #17732

wants to merge 1 commit into from

Conversation

nrb
Copy link

@nrb nrb commented Nov 22, 2019

PR #17430 added a link to the replicated stateless application example,
which isn't quite correct for the concepts that are meant to be
illustrated. A stateful application, such as MySQL, should have been the
actual target of the link.

Signed-off-by: Nolan Brubaker [email protected]

@nrb
Fix link to replicated stateful application
0adc2f4 
The original change added a link to the replicated stateless
application example, which isn't quite correct for the concepts
that are meant to be illustrated. A stateful application,
such as MySQL, should have been the actual target of the link.

Signed-off-by: Nolan Brubaker <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @nrb!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bradamant3
You can assign the PR to them by writing /assign @bradamant3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nrb
Copy link
Author

nrb commented Nov 22, 2019

/assign @Bradamant3

@nrb
Copy link
Author

nrb commented Nov 22, 2019

Actually this duplicates #17731, closing.

@nrb nrb closed this Nov 22, 2019
@nrb nrb deleted the fix-replicated-stateful-link branch November 22, 2019 06:01
@netlify
Copy link

netlify bot commented Nov 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0adc2f4

https://deploy-preview-17732--kubernetes-io-master-staging.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@Bradamant3 Bradamant3

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrb @k8s-ci-robot @Bradamant3