Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add link to running a replicated stateful application #17430

Merged
merged 1 commit into from Nov 7, 2019
Merged

add link to running a replicated stateful application #17430

merged 1 commit into from Nov 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 5, 2019

Fixes #13036

@k8s-ci-robot
Copy link
Contributor

Welcome @adityabhatia02!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from enisoc and kow3ns November 5, 2019 09:59
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2019
@netlify
Copy link

netlify bot commented Nov 5, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6ae2be2

https://deploy-preview-17430--kubernetes-io-master-staging.netlify.com

sftim
sftim approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adityabhatia02
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
@sftim
Copy link
Contributor

sftim commented Nov 6, 2019

Once this pull request is approved (an approver comments /approve), Prow will automatically merge it.

@makoscafee
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makoscafee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 488fbcb into kubernetes:master Nov 7, 2019
nrb added a commit to nrb/website that referenced this pull request Nov 22, 2019
@nrb
Fix link to replicated stateful application
583b659 
PR kubernetes#17430 added a link to the replicated stateless application example,
which isn't quite correct for the concepts that are meant to be
illustrated. A stateful application, such as MySQL, should have been the
actual target of the link.

Signed-off-by: Nolan Brubaker <[email protected]>
@nrb nrb mentioned this pull request Nov 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisoc enisoc Awaiting requested review from enisoc

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/concepts/workloads/controllers/statefulset/
3 participants
@k8s-ci-robot @sftim @makoscafee