Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate concepts/architecture/controller.md in Korean #16889

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Translate concepts/architecture/controller.md in Korean #16889

merged 3 commits into from
Oct 23, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Oct 14, 2019

신규 문서에 대한 번역을 진행했습니다.

원문의 일부 링크가 full url(ex: https://kubernetes.io/docs/tasks/administer-cluster/cluster-management/#cluster-autoscaling) 로 되어있어 이를 변경해서 적용했습니다.

full url로 되어 있는 부분에 대해서는 별도로 #16878 로 PR을 했습니다.

from #16717
/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 14, 2019
@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit fdf582c

https://deploy-preview-16889--k8s-dev-ko.netlify.com

@seokho-son
Copy link
Member

/assign @seokho-son

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 컨트리뷰션 감사합니다 ~~~ :)
리뷰 의견 남겼습니다. 참고하셔서 PR 업데이트 부탁드립니다.

content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
@ysyukr
Copy link
Member Author

ysyukr commented Oct 22, 2019

@seokho-son 리뷰 감사합니다.
주신 의견은 확인해서 반영했으며, 일부 의견에 대해 추가 의견을 남겼습니다.
검토 부탁드립니다. :)

@seokho-son
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2019
@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7c89994 into kubernetes:dev-1.16-ko.3 Oct 23, 2019
gochist added a commit that referenced this pull request Oct 24, 2019
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Oct 25, 2019
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
@ysyukr ysyukr deleted the translate-16717 branch October 25, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants