Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file outdated korean docs in dev-1.16-ko.3. #16876

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Update file outdated korean docs in dev-1.16-ko.3. #16876

merged 4 commits into from
Oct 22, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Oct 14, 2019

24 out of 26 files to be modified
업데이트 된 내용을 반영했습니다.
기타 변경사항은 기재된 내용 참고해주세요.

  • content/ko/docs/concepts/_index.md

한국어 문서 링크 반영

  • content/ko/docs/concepts/architecture/_index.md
  • content/ko/docs/concepts/architecture/cloud-controller.md
  • content/ko/docs/concepts/architecture/nodes.md

문서 유지보수를 위한 reviewer를 제외한 line 맞춤 진행, 한국어 문서 링크 반영

  • content/ko/docs/concepts/overview/components.md

한국어 문서 링크 반영

  • content/ko/docs/concepts/overview/what-is-kubernetes.md

문서 유지보수를 위한 line 맞춤 진행, 한국어 문서 링크 반영

  • content/ko/docs/concepts/overview/working-with-objects/kubernetes-objects.md

문서 유지보수를 위한 line 맞춤 진행, 한국어 문서 링크 반영

  • content/ko/docs/concepts/workloads/controllers/cron-jobs.md

문서 유지보수를 위한 line 맞춤 진행, 오타 및 누락사항 반영

  • content/ko/docs/concepts/workloads/controllers/daemonset.md
  • content/ko/docs/concepts/workloads/controllers/deployment.md

어색한 번역에 대한 재번역 진행

  • content/ko/docs/concepts/workloads/controllers/replicaset.md
  • content/ko/docs/concepts/workloads/controllers/statefulset.md
  • content/ko/docs/contribute/_index.md
  • content/ko/docs/reference/glossary/controller.md

전체 내용 변경으로 재번역 진행

  • content/ko/docs/reference/glossary/kube-apiserver.md

전체 내용 변경으로 재번역 진행

  • content/ko/docs/reference/glossary/kube-controller-manager.md
  • content/ko/docs/reference/glossary/statefulset.md
  • content/ko/docs/setup/_index.md
  • content/ko/docs/setup/learning-environment/minikube.md

한국어 문서 링크 반영

  • content/ko/docs/setup/production-environment/container-runtimes.md
  • content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md

리뷰어 삭제

  • content/ko/docs/tasks/manage-kubernetes-objects/imperative-config.md
  • content/ko/docs/tutorials/hello-minikube.md

문서 유지보수를 위한 line 맞춤 진행, 한국어 문서 링크 반영

  • content/ko/docs/tutorials/online-training/overview.md

Unmodified document and reason.

  • content/ko/docs/reference/glossary/cri.md

오타 변경으로 미번역 (CRI) is an an API -> (CRI) is an API

  • content/ko/docs/tasks/administer-cluster/cluster-management.md

Instance Group -> The Instance Group, start them -> starting them, Kubelet -> the Kubelet, API server -> the API server 등의 변경으로 미번역

from #16856
/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 14, 2019
@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit dd39100

https://deploy-preview-16876--k8s-dev-ko.netlify.com

@ysyukr ysyukr mentioned this pull request Oct 14, 2019
@gochist
Copy link
Member

gochist commented Oct 15, 2019

/assign

Copy link
Member

@gochist gochist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 감사합니다! 매번 생각보다 리뷰가 늦어져서 죄송합니다. 검토 의견 중 참고를 부탁드린 건은 선택적으로 반영 바랍니다.

@ysyukr
Copy link
Member Author

ysyukr commented Oct 21, 2019

@gochist 리뷰 감사합니다.
주신 의견은 참고해서 반영했으며, 영문 node 문서 뿐만 아니라 다른 문서에도 full url로 기재되어있는 링크를 확인해서 PR(#17057 ) 을 제출했습니다.

@gochist
Copy link
Member

gochist commented Oct 22, 2019

@ysyukr 감사합니다!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6fed679 into kubernetes:dev-1.16-ko.3 Oct 22, 2019
gochist added a commit that referenced this pull request Oct 24, 2019
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Oct 25, 2019
Update file outdated korean docs in dev-1.16-ko.3. (#16876)
Translate concepts/architecture/controller.md in Korean (#16889)
Change the full link in the document to an inline link. (#17059)
Add English-Korean translation glossary (#16664)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: June Yi <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
@ysyukr ysyukr deleted the outdated-16856 branch October 25, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants