Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-fr | reference | glossary | downstream.md #16074

Merged
merged 2 commits into from
Jan 1, 2020
Merged

docs-fr | reference | glossary | downstream.md #16074

merged 2 commits into from
Jan 1, 2020

Conversation

ryanzidago
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/fr Issues or PRs related to French language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 26, 2019
@netlify
Copy link

netlify bot commented Aug 26, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e1cd985

https://deploy-preview-16074--kubernetes-io-master-staging.netlify.com

oussemos
oussemos reviewed Aug 26, 2019
View reviewed changes
content/fr/docs/reference/glossary/downstream.md Outdated
@@ -0,0 +1,18 @@
---
title: En aval (désambiguïsation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je suis pas très fan de En aval
Je préfère plutôt garder downstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est remplacé.

oussemos
oussemos reviewed Oct 7, 2019
View reviewed changes
content/fr/docs/reference/glossary/downstream.md
@@ -0,0 +1,18 @@
---
title: Downstream (désambiguïsation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne suis pas sûr de comprendre l'utilité d'avoir désambiguïsation ici ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est ce qui est écrit dans la version originale anglaise : https://github.com/kubernetes/website/blob/master/content/en/docs/reference/glossary/downstream.md

Ils ont préféré laissé cette annotation, donc j'ai fais de même.

@rekcah78
Copy link
Contributor

rekcah78 commented Jan 1, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rekcah78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit 462bff5 into kubernetes:master Jan 1, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@ryanzidago @wawa0210
docs-fr | reference | glossary | downstream.md (kubernetes#16074)
7ea7c29 
* docs-fr | reference | glossary | downstream.md

* changed 'en aval' to 'downstream' instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oussemos oussemos oussemos left review comments

@rekcah78 rekcah78 Awaiting requested review from rekcah78

Assignees

@rekcah78 rekcah78

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/fr Issues or PRs related to French language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanzidago @rekcah78 @k8s-ci-robot @oussemos