#15788 removed vendor specific content #15919

jhbiggs · 2019-08-18T15:50:18Z

Fix: Issue #15788

It looks like each link in this page refers to vendor-specific content, so I removed all links. Did you intend to see ALL links removed?

k8s-ci-robot · 2019-08-18T15:50:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ryanmcginnis
You can assign the PR to them by writing /assign @ryanmcginnis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2019-08-18T15:57:47Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f1edb1f

https://deploy-preview-15919--kubernetes-io-master-staging.netlify.com

jhbiggs · 2019-08-18T20:58:42Z

/assign @ryanmcginnis

xiangpengzhao

I'm not sure if we want to keep the vendor specific content.
/cc @zacharysarah

xiangpengzhao · 2019-08-19T08:43:11Z

content/en/docs/concepts/architecture/nodes.md

@@ -21,7 +21,7 @@ architecture design doc for more details.

 {{% capture body %}}

-## Node Status
+### Node Status


It should be ## here because the below ### Addresses (and others) are parts of it.

Not sure this commit should be part of this PR

Yes, whoops, sorry, I'll undo the change.

thecrudge · 2019-08-19T15:30:32Z

My thought was to keep in line with the new style guide i.e. prometheus would be acceptable, but the GKE specific items would not. Possibly keep the linuxacademy CKA classes, but remove the Oracle related items, etc.

re: #15576

/cc @zacharysarah
/cc @jhbiggs

k8s-ci-robot · 2019-08-19T15:30:34Z

@thecrudge: GitHub didn't allow me to request PR reviews from the following users: jhbiggs.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

My thought was to keep in line with the new style guide i.e. prometheus would be acceptable, but the GKE specific items would not. Possibly keep the linuxacademy CKA classes, but remove the Oracle related items, etc.

re: #15576

/cc @zacharysarah
/cc @jhbiggs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…tyle-mark

…s#15788)

jhbiggs · 2019-08-19T20:49:57Z

I reviewed @thecrudge 's comment and adjusted the commit accordingly. Please let me know what you think.

zacharysarah

@jhbiggs Thanks for this PR! ✨ Some of the deletions need to remain. (The affiliation of the Linux Academy with the Linux Foundation, as well as the LF's relation to the CNCF aren't obvious but are valid.) Otherwise LGTM.

zacharysarah · 2019-08-19T23:53:33Z

content/en/docs/tutorials/online-training/overview.md

-
-* [Getting Started with Kubernetes Clusters on OCI Oracle Kubernetes Engine (OKE) (Learning Library)](https://apexapps.oracle.com/pls/apex/f?p=44785:50:0:::50:P50_EVENT_ID,P50_COURSE_ID:5935,256)
-
-* [Google Kubernetes Engine Deep Dive (Linux Academy)] (https://linuxacademy.com/google-cloud-platform/training/course/name/google-kubernetes-engine-deep-dive)


L32 should remain. (The Linux Academy partners with the Linux Foundation, which is the umbrella foundation for the CNCF.)

@zacharysarah why should L32 remain but L16 go? Both are Linux Academy links.

I actually believe both L32 and L16 should be removed if we're truly trying to be vendor-neutral on the website.

Sorry, @jaypipes maybe Im missing where he said L16 should go?

Scratch that, just looked at the commit. Yup, L16 should remain :)

Per today's weekly meeting, L16 should go because: even though it's a link from a permissible source, it's a link to third-party content. 😅

Good question, @jaypipes!

zacharysarah · 2019-08-19T23:54:02Z

content/en/docs/tutorials/online-training/overview.md

-
-* [Google Kubernetes Engine Deep Dive (Linux Academy)] (https://linuxacademy.com/google-cloud-platform/training/course/name/google-kubernetes-engine-deep-dive)
-
-* [Helm Deep Dive with Hands-On Labs (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/helm-deep-dive-part-1)


L34 should remain. (The Linux Academy partners with the Linux Foundation, which is the umbrella foundation for the CNCF.)

zacharysarah · 2019-08-19T23:55:36Z

content/en/docs/tutorials/online-training/overview.md

 * [Kubernetes Essentials with Hands-On Labs (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/kubernetes-essentials)

-* [Kubernetes for the Absolute Beginners with Hands-on Labs (KodeKloud)](https://kodekloud.com/p/kubernetes-for-the-absolute-beginners-hands-on)
-
-* [Kubernetes Fundamentals (LFS258) (The Linux Foundation)](https://training.linuxfoundation.org/training/kubernetes-fundamentals/)


L46 should remain. (The Linux Foundation is the umbrella foundation for the CNCF.)

zacharysarah · 2019-08-19T23:56:58Z

content/en/docs/tutorials/online-training/overview.md

@@ -55,15 +31,5 @@ Here are some of the sites that offer online training for Kubernetes:

 * [Learn Kubernetes by Doing - 100% Hands-On Experience (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/learn-kubernetes-by-doing)

-* [Learn Kubernetes using Interactive Hands-on Scenarios (Katacoda)](https://www.katacoda.com/courses/kubernetes/)
-
-* [Microservice Applications in Kubernetes - 100% Hands-On Experience (Linux Academy)] (https://linuxacademy.com/devops/training/course/name/learn-microservices-by-doing)


L60 should remain. (The Linux Academy partners with the Linux Foundation, which is the umbrella foundation for the CNCF.)

zacharysarah · 2019-08-19T23:57:26Z

content/en/docs/tutorials/online-training/overview.md

 * [Monitoring Kubernetes With Prometheus with Hands-On Labs (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/kubernetes-and-prometheus)
-
-* [Service Mesh with Istio with Hands-On Labs (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/service-mesh-with-istio-part-1)


L64 should remain. (The Linux Academy partners with the Linux Foundation, which is the umbrella foundation for the CNCF.)

thecrudge · 2019-08-20T00:54:59Z

Thanks for the review @zacharysarah , youre awesome!

jaypipes

I think we should discuss this :)

jaypipes · 2019-08-20T16:47:31Z

content/en/docs/tutorials/online-training/overview.md

-
-* [Getting Started with Kubernetes Clusters on OCI Oracle Kubernetes Engine (OKE) (Learning Library)](https://apexapps.oracle.com/pls/apex/f?p=44785:50:0:::50:P50_EVENT_ID,P50_COURSE_ID:5935,256)
-
-* [Google Kubernetes Engine Deep Dive (Linux Academy)] (https://linuxacademy.com/google-cloud-platform/training/course/name/google-kubernetes-engine-deep-dive)


@zacharysarah why should L32 remain but L16 go? Both are Linux Academy links.

I actually believe both L32 and L16 should be removed if we're truly trying to be vendor-neutral on the website.

jhbiggs · 2019-08-22T00:28:41Z

I added back the links I was pretty sure were agreeable. I'll make another change when you figure out the 16/32 controversy ;)

zacharysarah · 2019-10-08T21:47:08Z

Holding for the results of the KEP arising from #15748.

/hold

fejta-bot · 2020-01-06T22:35:48Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2020-01-06T22:35:55Z

@jhbiggs: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2020-02-05T23:17:34Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

zacharysarah · 2020-02-05T23:18:53Z

/remove-lifecycle rotten

kbhawkey · 2020-02-10T22:12:22Z

I am closing this PR until a decision has been made about #15748.
Feel free to reopen this PR or create a new PR.
/close

k8s-ci-robot · 2020-02-10T22:12:24Z

@kbhawkey: Closed this PR.

In response to this:

I am closing this PR until a decision has been made about #15748.
Feel free to reopen this PR or create a new PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2019

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 18, 2019

k8s-ci-robot requested review from stewart-yu and zhangxiaoyu-zidif August 18, 2019 15:50

k8s-ci-robot assigned ryanmcginnis Aug 18, 2019

xiangpengzhao reviewed Aug 19, 2019

View reviewed changes

k8s-ci-robot requested a review from zacharysarah August 19, 2019 08:44

kubernetes#15788 remove vendor specific content

35e1565

jhbiggs force-pushed the #15788-remove-vendor-specific-content branch from 46feb1b to 35e1565 Compare August 19, 2019 20:37

ryanmcginnis removed their assignment Aug 19, 2019

jhbiggs added 2 commits August 19, 2019 15:41

kubernetes#15788-remove-vendor-specific-content-and-revert-previous-s…

d280610

…tyle-mark

Remove vendor-specific content and correct arch nodes page (kubernete…

30f2f83

…s#15788)

zacharysarah suggested changes Aug 20, 2019

View reviewed changes

aimeeu mentioned this pull request Aug 20, 2019

Style Guide: Clarify Adding Third-Party Content #15892

Merged

jaypipes reviewed Aug 20, 2019

View reviewed changes

aimeeu mentioned this pull request Aug 20, 2019

Adding new course resource #15962

Closed

Add back in some links (kubernetes#15788)

f1edb1f

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2019

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2020

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 5, 2020

k8s-ci-robot closed this Feb 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#15788 removed vendor specific content #15919

#15788 removed vendor specific content #15919

jhbiggs commented Aug 18, 2019

k8s-ci-robot commented Aug 18, 2019

netlify bot commented Aug 18, 2019 •

edited

Loading

jhbiggs commented Aug 18, 2019

xiangpengzhao left a comment

xiangpengzhao Aug 19, 2019

thecrudge Aug 19, 2019

jhbiggs Aug 19, 2019

thecrudge commented Aug 19, 2019

k8s-ci-robot commented Aug 19, 2019

jhbiggs commented Aug 19, 2019

zacharysarah left a comment

zacharysarah Aug 19, 2019

jaypipes Aug 20, 2019

thecrudge Aug 20, 2019

thecrudge Aug 20, 2019

zacharysarah Aug 20, 2019

zacharysarah Aug 19, 2019

zacharysarah Aug 19, 2019

zacharysarah Aug 19, 2019

zacharysarah Aug 19, 2019

thecrudge commented Aug 20, 2019

jaypipes left a comment

jaypipes Aug 20, 2019

jhbiggs commented Aug 22, 2019

zacharysarah commented Oct 8, 2019

fejta-bot commented Jan 6, 2020

k8s-ci-robot commented Jan 6, 2020

fejta-bot commented Feb 5, 2020

zacharysarah commented Feb 5, 2020

kbhawkey commented Feb 10, 2020

k8s-ci-robot commented Feb 10, 2020


		* [Getting Started with Kubernetes Clusters on OCI Oracle Kubernetes Engine (OKE) (Learning Library)](https://apexapps.oracle.com/pls/apex/f?p=44785:50:0:::50:P50_EVENT_ID,P50_COURSE_ID:5935,256)

		* [Google Kubernetes Engine Deep Dive (Linux Academy)] (https://linuxacademy.com/google-cloud-platform/training/course/name/google-kubernetes-engine-deep-dive)


		* [Google Kubernetes Engine Deep Dive (Linux Academy)] (https://linuxacademy.com/google-cloud-platform/training/course/name/google-kubernetes-engine-deep-dive)

		* [Helm Deep Dive with Hands-On Labs (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/helm-deep-dive-part-1)

		* [Monitoring Kubernetes With Prometheus with Hands-On Labs (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/kubernetes-and-prometheus)

		* [Service Mesh with Istio with Hands-On Labs (Linux Academy)] (https://linuxacademy.com/linux/training/course/name/service-mesh-with-istio-part-1)

#15788 removed vendor specific content #15919

#15788 removed vendor specific content #15919

Conversation

jhbiggs commented Aug 18, 2019

k8s-ci-robot commented Aug 18, 2019

netlify bot commented Aug 18, 2019 • edited Loading

jhbiggs commented Aug 18, 2019

xiangpengzhao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thecrudge commented Aug 19, 2019

k8s-ci-robot commented Aug 19, 2019

jhbiggs commented Aug 19, 2019

zacharysarah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thecrudge commented Aug 20, 2019

jaypipes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jhbiggs commented Aug 22, 2019

zacharysarah commented Oct 8, 2019

fejta-bot commented Jan 6, 2020

k8s-ci-robot commented Jan 6, 2020

fejta-bot commented Feb 5, 2020

zacharysarah commented Feb 5, 2020

kbhawkey commented Feb 10, 2020

k8s-ci-robot commented Feb 10, 2020

netlify bot commented Aug 18, 2019 •

edited

Loading