Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor specific content from online training overview #15788

Closed
thecrudge opened this issue Aug 10, 2019 · 14 comments
Closed

Remove vendor specific content from online training overview #15788

thecrudge opened this issue Aug 10, 2019 · 14 comments
Assignees
@rusik69
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@thecrudge
Copy link
Contributor

Problem:
Keeping in line with the updated style guide (see #15576), we should also remove the vendor specific references on the online training overview page

Proposed Solution:
Remove the links

Page to Update:
https://kubernetes.io/docs/tutorials/online-training/overview/

/good-first-issue
@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 10, 2019
@thecrudge
Copy link
Contributor Author

/cc @zacharysarah

@rusik69
Copy link

rusik69 commented Aug 10, 2019

/assign

@rusik69 rusik69 removed their assignment Aug 10, 2019
@thecrudge
Copy link
Contributor Author

Linked wrong Issue, #15748

@thecrudge
Copy link
Contributor Author

thecrudge commented Aug 10, 2019 •
edited
Loading

/assign @Loqutus

Assigned, just keep in mind that issues are first come first serve. If someone submits a PR first, its theirs to claim. When you do submit your PR, make sure to add in the comments NOT THE COMMIT OR TITLE, but in the comments, this issue #.

jhbiggs added a commit to jhbiggs/website that referenced this issue Aug 18, 2019
@jhbiggs
kubernetes#15788 removed vendor specific content
367b20c
@jhbiggs jhbiggs mentioned this issue Aug 18, 2019
Closed
@jhbiggs
Copy link
Contributor

jhbiggs commented Aug 18, 2019

Not sure if it's what you meant, but committed above for pull request.

jhbiggs added a commit to jhbiggs/website that referenced this issue Aug 18, 2019
@jhbiggs
kubernetes#15788 remove vendor sites plus added placeholder text to p…
46feb1b 
…revent error
jhbiggs added a commit to jhbiggs/website that referenced this issue Aug 19, 2019
@jhbiggs
kubernetes#15788 remove vendor specific content
35e1565
jhbiggs added a commit to jhbiggs/website that referenced this issue Aug 19, 2019
@jhbiggs
kubernetes#15788-remove-vendor-specific-content-and-revert-previous-s…
d280610 
…tyle-mark
jhbiggs added a commit to jhbiggs/website that referenced this issue Aug 19, 2019
@jhbiggs
Remove vendor-specific content and correct arch nodes page (kubernete…
30f2f83 
…s#15788)
jhbiggs added a commit to jhbiggs/website that referenced this issue Aug 22, 2019
@jhbiggs
Add back in some links (kubernetes#15788)
f1edb1f
@sftim
Copy link
Contributor

sftim commented Sep 10, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 10, 2019
@dims
Copy link
Member

dims commented Sep 13, 2019 •
edited
Loading

/hold

please see the hold on the umbrella issue

@sftim
Copy link
Contributor

sftim commented Nov 20, 2019

/remove-good-first-issue

@k8s-ci-robot k8s-ci-robot removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Nov 20, 2019
@sftim
Copy link
Contributor

sftim commented Nov 20, 2019

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 20, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 19, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Apr 18, 2020

/hold cancel
(it's already closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rusik69 rusik69

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dims @rusik69 @k8s-ci-robot @sftim @fejta-bot @jhbiggs @thecrudge