Clean up the kubeadm high availability instructions. Fixes Issue 15284 #15411

rcythr · 2019-07-13T21:53:34Z

k8s-ci-robot · 2019-07-13T21:53:35Z

Welcome @rcythr!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-07-13T21:53:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kbarnard10
You can assign the PR to them by writing /assign @kbarnard10 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2019-07-13T22:01:07Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a586b71

https://deploy-preview-15411--kubernetes-io-master-staging.netlify.com

… specific method for setting up a load balancer. Removed extra space. Fixed indentation.

rcythr · 2019-07-13T22:37:26Z

/sig cluster-lifecycle

kbhawkey · 2019-07-14T12:27:23Z

hello @rcythr , would you coordinate with PR #15372. Thanks!

fabriziopandini

@rcythr Thanks for this PR!
I'm ok with the change, with only a minor nit

fabriziopandini · 2019-07-15T07:14:18Z

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md


-    - Make sure the address of the load balancer always matches
-      the address of kubeadm's `ControlPlaneEndpoint`.
+  - Check if your deployment environment has a highly available load balancer, and use that if possible. Otherwise, setup a TCP forwarding load balancer (such as [HAProxy](http://www.haproxy.org/)). Make sure to follow the documentation to properly setup this load balancer in a highly-available configuration. Otherwise, your load balancer becomes a single point of failure.


After re-reading, I think this sentence should become the first point (first check what you have, second create). Also, plese change "Otherwise, setup a TCP forwarding load balancer (such as HAProxy)" into Otherwise, "select a TCP forwarding load balancer such as HAProxy", in order to be more in line with the "check what you have" message

tengqm · 2019-07-21T08:43:31Z

@rcythr Feedback reasonable to you?

rcythr · 2019-07-21T10:55:41Z

@fabriziopandini How about this? Sorry for the delay, I've been swamped this week.

@tengqm Thanks for the reminder.

fabriziopandini · 2019-07-22T07:47:35Z

@rcythr thanks for the updates! I'm ok with the changes, I leave to @neolit123 giving the final green light

neolit123

/lgtm

rcythr · 2019-07-23T12:06:07Z

/assign @kbarnard10

rcythr · 2019-07-25T03:24:53Z

/hold

In light of kubernetes/kubeadm#1685 we should revise our advice to be more explicit about what kind of things the LB needs to be able to do. Azure's LB currently cannot fulfil those requirements.

…want to get into details of specific LB implementation. Added HA LB as a required piece of infrastructure where it belongs.

k8s-ci-robot · 2019-07-28T00:57:03Z

New changes are detected. LGTM label has been removed.

rcythr · 2019-07-28T00:58:56Z

@neolit123 @fabriziopandini I modified the text to make the HA LB a requirement instead of trying to provide steps for setting it up -- we can't get into details about the specific implementations. I added a note about hairpin NAT in light of kubernetes/kubeadm#1685

What do you think?

rcythr · 2019-07-28T01:28:41Z

/hold cancel
I have adjusted this to incorporate content from kubernetes/kubeadm#1685.

neolit123 · 2019-07-28T19:47:32Z

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md

@@ -40,6 +40,7 @@ For both methods you need this infrastructure:
  the masters
 - Three machines that meet [kubeadm's minimum
  requirements](/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#before-you-begin) for the workers
+- A highly available load balancer that operates at Layer 4 (such as one provided by a cloud provider, or [HAProxy](http://www.haproxy.org/)) with it's own name in DNS. The load balancer should be configured to forward the apiserver port (default: 6443) on the load balancer to the apiserver port on all control plane nodes. Before using a cloud provider provided load balancer, double check the documentation for [NAT hairpinning](https://en.wikipedia.org/wiki/Hairpinning) support.


we should probably mention HTTPS and health checks here.
@ereslibre @fabriziopandini how would you word that?

I would say that even if it's a layer 4 LB it should have the ability to perform HTTPS health checks (even if the certificate chain is ignored) against every apiserver /healthz endpoint. That way it will remove from the active pool unhealthy apiservers.

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md

…h-availability.md Fixed it's vs its. Co-Authored-By: Rafael Fernández López <[email protected]>

zacharysarah · 2019-08-05T23:53:15Z

@rcythr 👋 Any updates?

zacharysarah · 2019-08-06T22:30:32Z

@rcythr 👋 Please feel free to /reopen when you're ready to continue.

/close

k8s-ci-robot · 2019-08-06T22:30:34Z

@zacharysarah: Closed this PR.

In response to this:

@rcythr 👋 Please feel free to /reopen when you're ready to continue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

First attempt to clean up the kubeadm high availability instructions.

282c2ba

k8s-ci-robot assigned fabriziopandini and neolit123 Jul 13, 2019

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2019

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2019

k8s-ci-robot requested review from Rajakavitha1 and zhangxiaoyu-zidif July 13, 2019 21:53

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 13, 2019

Removed unnecessary note -- the current documentation does not show a…

4aef7b6

… specific method for setting up a load balancer. Removed extra space. Fixed indentation.

rcythr changed the title ~~First attempt to clean up the kubeadm high availability instructions.~~ Clean up the kubeadm high availability instructions. Fixes #15284 Jul 13, 2019

rcythr changed the title ~~Clean up the kubeadm high availability instructions. Fixes #15284~~ Clean up the kubeadm high availability instructions. Fixes Issue 15284 Jul 13, 2019

k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 13, 2019

fabriziopandini suggested changes Jul 15, 2019

View reviewed changes

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 21, 2019

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 21, 2019

Adjusting according to PR feedback.

1a56200

neolit123 reviewed Jul 22, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019

k8s-ci-robot assigned kbarnard10 Jul 23, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2019

Removed 'steps' because they don't provide much value since we don't …

d72fb80

…want to get into details of specific LB implementation. Added HA LB as a required piece of infrastructure where it belongs.

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2019

neolit123 reviewed Jul 28, 2019

View reviewed changes

neolit123 mentioned this pull request Jul 28, 2019

HA: improvements to the load balancer documentation kubernetes/kubeadm#1685

Closed

ereslibre reviewed Jul 28, 2019

View reviewed changes

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md Outdated Show resolved Hide resolved

Update content/en/docs/setup/production-environment/tools/kubeadm/hig…

a586b71

…h-availability.md Fixed it's vs its. Co-Authored-By: Rafael Fernández López <[email protected]>

zacharysarah mentioned this pull request Aug 5, 2019

Issue with k8s.io/docs/setup/production-environment/tools/kubeadm/hig… #15372

Closed

k8s-ci-robot closed this Aug 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up the kubeadm high availability instructions. Fixes Issue 15284 #15411

Clean up the kubeadm high availability instructions. Fixes Issue 15284 #15411

rcythr commented Jul 13, 2019

k8s-ci-robot commented Jul 13, 2019

k8s-ci-robot commented Jul 13, 2019

netlify bot commented Jul 13, 2019 •

edited

Loading

rcythr commented Jul 13, 2019

kbhawkey commented Jul 14, 2019

fabriziopandini left a comment

fabriziopandini Jul 15, 2019

tengqm commented Jul 21, 2019

rcythr commented Jul 21, 2019

fabriziopandini commented Jul 22, 2019

neolit123 left a comment

rcythr commented Jul 23, 2019

rcythr commented Jul 25, 2019

k8s-ci-robot commented Jul 28, 2019

rcythr commented Jul 28, 2019

rcythr commented Jul 28, 2019

neolit123 Jul 28, 2019

ereslibre Jul 28, 2019 •

edited

Loading

zacharysarah commented Aug 5, 2019

zacharysarah commented Aug 6, 2019

k8s-ci-robot commented Aug 6, 2019

Clean up the kubeadm high availability instructions. Fixes Issue 15284 #15411

Clean up the kubeadm high availability instructions. Fixes Issue 15284 #15411

Conversation

rcythr commented Jul 13, 2019

k8s-ci-robot commented Jul 13, 2019

k8s-ci-robot commented Jul 13, 2019

netlify bot commented Jul 13, 2019 • edited Loading

rcythr commented Jul 13, 2019

kbhawkey commented Jul 14, 2019

fabriziopandini left a comment

Choose a reason for hiding this comment

fabriziopandini Jul 15, 2019

Choose a reason for hiding this comment

tengqm commented Jul 21, 2019

rcythr commented Jul 21, 2019

fabriziopandini commented Jul 22, 2019

neolit123 left a comment

Choose a reason for hiding this comment

rcythr commented Jul 23, 2019

rcythr commented Jul 25, 2019

k8s-ci-robot commented Jul 28, 2019

rcythr commented Jul 28, 2019

rcythr commented Jul 28, 2019

neolit123 Jul 28, 2019

Choose a reason for hiding this comment

ereslibre Jul 28, 2019 • edited Loading

Choose a reason for hiding this comment

zacharysarah commented Aug 5, 2019

zacharysarah commented Aug 6, 2019

k8s-ci-robot commented Aug 6, 2019

netlify bot commented Jul 13, 2019 •

edited

Loading

ereslibre Jul 28, 2019 •

edited

Loading