Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with k8s.io/docs/setup/production-environment/tools/kubeadm/hig… #15372

Closed
wants to merge 1 commit into from
Closed

Issue with k8s.io/docs/setup/production-environment/tools/kubeadm/hig… #15372

wants to merge 1 commit into from

Conversation

RA489
Copy link

@RA489 RA489 commented Jul 11, 2019

Issue with k8s.io/docs/setup/production-environment/tools/kubeadm/hig…
fixes #15284

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bradamant3
You can assign the PR to them by writing /assign @bradamant3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 11, 2019
@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5847d2c

https://deploy-preview-15372--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Contributor

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 12, 2019
kbhawkey
kbhawkey reviewed Jul 12, 2019
View reviewed changes
content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md
an apiserver is a TCP check on the port the kube-apiserver listens on
(default value `:6443`).
- In a cloud environment, use the load balancer infrastructure provided by the cloud provider.
In an environment without a built-in load balancer (i.e. bare metal), you can use a TCP forwarding proxy,such as HAProxy, however you need to take steps to make that load balancer highly available. Otherwise your load balancer becomes a single point of failure. The health check for an apiserver is a TCP check on the port the kube-apiserver listens on (default value `:6443`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @RA489. Thanks for the PR.
I reread the comments from issue #15284.
It seems as if there could be three bullet points instead of a single paragraph, 1) cloud provider 2) bare metal 3) health check, if it applies to both environments

  • The bare metal sentence could be split into two or more sentences. Possible edit:
    In an environment without a built-in load balancer, such as bare metal, you can use a TCP forwarding proxy. However, ...
  • There is an item further below in the list that refers to HAProxy.

@kbhawkey kbhawkey mentioned this pull request Jul 14, 2019
Closed
@fabriziopandini
Copy link
Member

/hold
should coordinate with #15372 (from the contributor who filed the issue)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2019
@neolit123 neolit123 mentioned this pull request Jul 25, 2019
Closed
@zacharysarah
Copy link
Contributor

Closing in deference to #15411.

/close

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Closed this PR.

In response to this:

Closing in deference to #15411.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/setup/production-environment/tools/kubeadm/high-availability/
5 participants
@RA489 @k8s-ci-robot @kbhawkey @fabriziopandini @zacharysarah