Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate CronJob to Bahasa Indonesia #14382

Closed
wants to merge 2 commits into from

Conversation

yohanesmario
Copy link

This PR addresses #13929

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: girikuncoro

If they are not already assigned, you can assign the PR to them by writing /assign @girikuncoro in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 17, 2019
@yohanesmario
Copy link
Author

/assign @girikuncoro

@netlify
Copy link

netlify bot commented May 17, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b332850

https://deploy-preview-14382--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, great job on translating this page! 🎉

Looking good, you just need to fix formatting for CronJob, Job, Pod with camelcase (without italic) if those words are used with context of Kubernetes objects. (As per https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects)

But if those words are used in the context of english words, you just need to do italic for it.

Seluruh waktu `schedule:` pada _**CronJob**_ mengikuti zona waktu dari _master_ di mana _job_ diinisiasi.
{{< /note >}}

Untuk panduan dalam berkreasi dengan _cron job_, dan contoh _spec file_ untuk suatu _cron job_, lihat [Running automated tasks with cron jobs](/docs/tasks/job/automated-tasks-with-cron-jobs).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should translate "Running automated tasks with cron jobs" as well


{{% capture overview %}}

Suatu _CronJob_ menciptakan [_Job_](/docs/concepts/workloads/controllers/jobs-run-to-completion/) yang dijadwalkan berdasarkan waktu tertentu.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CronJob and Job are Kubernetes objects. Should be written as camel case without italic (unless it's referring to cron job / job as english word -- not as the kube object).

ref: https://kubernetes.io/docs/contribute/style/style-guide/#use-camel-case-for-api-objects

Same comment applies for the rest on this page

@girikuncoro
Copy link
Contributor

@yohanesmario any update on this?

@girikuncoro
Copy link
Contributor

This got moved to #14933 which was merged, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants