Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for AWS EBS plugin migration #13115

Closed
wants to merge 1 commit into from
Closed

Update documentation for AWS EBS plugin migration #13115

wants to merge 1 commit into from

Conversation

leakingtapan
Copy link

Docs for CSI Migration Alpha for AWS EBS

Parent feature doc: #12935

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhangxiaoyu-zidif

If they are not already assigned, you can assign the PR to them by writing /assign @zhangxiaoyu-zidif in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali March 11, 2019 21:05
@leakingtapan
Copy link
Author

/cc @ddebroy @d-nishi

@k8s-ci-robot k8s-ci-robot requested review from d-nishi and ddebroy March 11, 2019 21:06
@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9250f89

https://deploy-preview-13115--kubernetes-io-master-staging.netlify.com

@ddebroy
Copy link
Member

ddebroy commented Mar 11, 2019

lgtm for tech. review.

msau42
msau42 reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's coordinate this with #13044 so that the wording is consistent between plugins

content/en/docs/concepts/storage/volumes.md

{{< feature-state for_k8s_version="v1.14" state="alpha" >}}

To enable the feature, set `CSIMigration` and `CSIMigrationAWS` alpha feature gates to `true`. Once enabled, this feature shims all plugin operations from in-tree `awsElasticBlockStore` plugin to [AWS EBS CSI Driver](https://github.com/kubernetes-sigs/aws-ebs-csi-driver). To use this feature, AWS EBS CSI driver must be installed on the cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update feature-gates.md.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind just saw this in the parent pr

@ddebroy
Copy link
Member

ddebroy commented Mar 13, 2019

Consolidated under #12935. This PR may be closed.

@leakingtapan
Copy link
Author

/close

@k8s-ci-robot
Copy link
Contributor

@leakingtapan: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leakingtapan leakingtapan deleted the ebs-migration branch August 28, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@d-nishi d-nishi Awaiting requested review from d-nishi

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leakingtapan @k8s-ci-robot @ddebroy @msau42